[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    RE: konqy issues (22.02.2000)
From:       David Faure <David.Faure () cramersystems ! com>
Date:       2000-03-01 10:38:36
[Download RAW message or body]

> On Die, 29 Feb 2000, Michael Reiher wrote:
> > > I also agree that menu items that appear and disappear are not
> > > a good practice, and I love your suggested menu layout !
> > We actually just need some kind of "standard" how the 
> menuitems should
> > be arranged and then each view proviedes a similar 
> structure. This way
> > it seems to the user that it always stays the same 
> (mostly). Only the
> > View Mode entry would need to be somehow static. But the Iconview,
> > Treeview entries already do btw.
> 
> Yes, this is what I tried to say.
> 
> About the merging, I will commit next week or the week after 
> next week, I think it is quite different from the tree view, I don't think
it 
> should be merged, but let's see.
>
> And I remember David said last week something like "To much 
> configurability is hard to maintain, since the maintainer will always use 
> the same configuration" (with kwm focus modes in mind).

Hehe, my own argument used against me :-)
I think there is a major distinction to do here:

When configurability means a completely different behaviour,
with some code that is used only in some cases, then indeed
it's hard to maintain. With kwm focus stuff, there is a different
code for each focus, and different behaviours (i.e. different bugs...)
which is why it was a nightmare (allegedly).

When configuration is just about :
large icons or small icons, text or no text, show subdirs or don't...
it is easier to maintain if it is one single piece of code.

> I would/will happily maintain the textview, since this is the 
> one I will use.

I think the MAIN question here is : is your view based on QListView ?
If yes, merging makes sense to me, because as far as I can see
it falls into the "small configuration differences" case above.

Of course this shouldn't prevent your from committing - so that we
know better what we're talking about - and then we'll decide on this.

About the dirtree, one thing that struck me as different from the
treeview is the fact that only ONE item can be selected at a time,
whereas in the treeview you can select more than one item.
Not a huge difference though, so it doesn't prevent the merging there
either, but something to keep in mind. (i.e. whoever merges will have
to add a "can select more than one item" flag somewhere, I guess).

David.

[prev in list] [next in list] [prev in thread] [next in thread]