[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Template-Menu
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-02-28 18:37:27
[Download RAW message or body]

On Mon, Feb 28, 2000 at 06:52:29PM +0100, Christoph Pickart wrote:
> Hello,
> 
> I changed the templates-menu and patched it against
> the sources from saturday. Hope it's recent enough.
> I made a tar.gz file with the patch and a sample template folder
> for testing. It contains the links to the templates in
> the kdesktop-directory, one link to a plain html file
> in Templates/.sources and an ordinary text file.
> As I don't know how and to whom I can send it, you can get it from
> http://www.iam.uni-bonn.de/~pickart/patch_knewmenu.tar.gz

Hi, I had a look at it.
Hmm, I'm a bit confused.

My idea would be to put in the kdesktop directory ALL sources, including
the html file and the text file... but of course a user can set it
the way you did. I just wouldn't create any .sources by default.

Ok, so if we have the links, with translated names in Templates/,
and they point to the global files.... The links should NOT use
$KDEDIR (this is deprecated since a very long time. Think about
the FHS, and about KDEDIRS...). But since the links could be set up
by kdesktop on first startup, they could easily point to the actual
templates... as long as nobody changes his KDEDIR(S) after that. Hmm, ok.

Next thing: you've put support for Type=Application in the _link_ ?
This makes no sense to me. A link is a link...
Looks like you tried to launch the app when doing New/Document.
Are you sure you want to do that ?
1 - when doing it from a document, it should use KRun (i.e. do
just like a left click on the document, find the associated application)
2 - Type=Application is the definition of an application, but not of
a link to a document at the same time. Your patch launches an application,
but with no document at all...

Other than that, I still like the idea, because it makes it possible
to ship templates for empty text file and empty html file, with an 
appropriate (translatable) description in the .desktop link.

So the first part of the patch is roughly ok (the Type=Link one)
Most of the work is also to provide correct templates (and create the links
correctly in kdesktop's startup code).

Ah oh, and you lost support for the existing templates... Hmmm.. Not sure
whether we can still honour the existing .dessktop files. (At least
those with Type=Link, no problem for the others). Well, kdesktop
will overwrite them, then.

> I thinked about the problem with the updates when a new KDE
> version is installed. Why don't do it like with the applnk directory
> First you parse the folder for the system templates and then the templates 
> folder of the desktop?

Because the problem wasn't only providing more templates but also updating the
existing ones, mostly to add translations to them.

And if we parse a system templates dir, then we also have to support
a way for the user to 'hide' some of those (like we do in the K menu,
with Hidden=true). Well, that could be done, but it's another story :)
You'll do that next :-)


PS: do diffs the other way round (diff old new, not diff new old)

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]