[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    FW: kdebase-1.1.2pre-19990819
From:       David Faure <David.Faure () CRAMER ! CO ! UK>
Date:       1999-08-31 7:54:24
[Download RAW message or body]

Hi Dawit.
It seems my suggestion for the thumbnail problem works.
Stefan Siegel reports so. But I can't commit since I have no
Unix box connected to the net.
Please apply the attached patch to the KDE-1.1.x branch,
and commit the attached file "mimelnk/image/x-bmp.kdelnk".

--
David Faure
faure@kde.org - KDE developer
david@mandrakesoft.com - Mandrake
david.faure@cramer.co.uk - Cramer Systems



> -----Original Message-----
> From: Stefan Siegel [mailto:siegel@informatik.uni-kl.de]
> Sent: Monday, August 30, 1999 10:16 AM
> To: David Faure
> Subject: Re: kdebase-1.1.2pre-19990819
> 
> 
> Bonjour David,
> 
> Je t'en voye le <<patch>> contre kdebase-1.1.2pre3. Il a fonctionne
> très bien tou le week-end ici. Sauf les formats d'images que je
> n'avais pas sur ma machine (regarede dernière Mél) je ne vois rien,
> que pourrais nous empecher d'introduire cette functionalité.
> 
> Bonne chanche que tu réussira a l'implanter en KDE 1.(1.)2
> 
> P.S. n'oublie pas a introduire en meme temps le fichier
>      "mimelnk/image/x-bmp.kdelnk".
> 
> -- 
> Tschüss und bis demnächst,
> 
> 			Stefan
>  
> +----------------------------------------------+
> |  Stefan Siegel                               |
> |  Kurt-Schumacher-Str. 34 / App. 144          |
> |  D-67663 Kaiserslautern                      |
> |  Tel.: +49-631-18269                         |
> |                                              |
> |  mailto:siegel@informatik.uni-kl.de          |
> |  PGP Public Key:                             |
> |  finger s_siegel@mikado.informatik.uni-kl.de |
> +----------------------------------------------+
> 


["kdebase-1.1.2pre3-thumbnail.patch" (text/plain)]

diff -uNr kdebase/kfm/kfmman.cpp kdebase.new/kfm/kfmman.cpp
--- kdebase/kfm/kfmman.cpp	Thu Aug 19 17:15:01 1999
+++ kdebase.new/kfm/kfmman.cpp	Fri Aug 27 20:28:06 1999
@@ -1812,11 +1812,7 @@
     
 	// At this time the icon protocol works for local files only.
 	KMimeType *mime = KMimeType::getMagicMimeType( _url );
-	if ( strcmp( mime->getMimeType(), "image/jpeg" ) == 0 ||
-	     strcmp( mime->getMimeType(), "image/gif" ) == 0 ||
-	     strcmp( mime->getMimeType(), "image/bmp" ) == 0 ||  
-                            // Added bmp, because it seems to work. David.
-	     strcmp( mime->getMimeType(), "image/x-xpm" ) == 0 )
+        if ( strncmp( mime->getMimeType(), "image/", 6 ) == 0 )
 	{
 	    QString result;
             QString path(u2.path());

["x-bmp.kdelnk" (text/plain)]

# KDE Config File
[KDE Desktop Entry]
Type=MimeType
MimeType=image/x-bmp
Icon=image.xpm
Patterns=*.bmp;*.BMP;
Comment=bitmap image


[prev in list] [next in list] [prev in thread] [next in thread]