From kfm-devel Tue Aug 31 07:54:24 1999 From: David Faure Date: Tue, 31 Aug 1999 07:54:24 +0000 To: kfm-devel Subject: FW: kdebase-1.1.2pre-19990819 X-MARC-Message: https://marc.info/?l=kfm-devel&m=93608572526601 MIME-Version: 1 Content-Type: multipart/mixed; boundary="------_=_NextPart_000_01BEF386.0BF3A83C" This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. ------_=_NextPart_000_01BEF386.0BF3A83C Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Dawit. It seems my suggestion for the thumbnail problem works. Stefan Siegel reports so. But I can't commit since I have no Unix box connected to the net. Please apply the attached patch to the KDE-1.1.x branch, and commit the attached file "mimelnk/image/x-bmp.kdelnk". -- David Faure faure@kde.org - KDE developer david@mandrakesoft.com - Mandrake david.faure@cramer.co.uk - Cramer Systems > -----Original Message----- > From: Stefan Siegel [mailto:siegel@informatik.uni-kl.de] > Sent: Monday, August 30, 1999 10:16 AM > To: David Faure > Subject: Re: kdebase-1.1.2pre-19990819 >=20 >=20 > Bonjour David, >=20 > Je t'en voye le <> contre kdebase-1.1.2pre3. Il a fonctionne > tr=E8s bien tou le week-end ici. Sauf les formats d'images que je > n'avais pas sur ma machine (regarede derni=E8re M=E9l) je ne vois = rien, > que pourrais nous empecher d'introduire cette functionalit=E9. >=20 > Bonne chanche que tu r=E9ussira a l'implanter en KDE 1.(1.)2 >=20 > P.S. n'oublie pas a introduire en meme temps le fichier > "mimelnk/image/x-bmp.kdelnk". >=20 > --=20 > Tsch=FCss und bis demn=E4chst, >=20 > Stefan > =20 > +----------------------------------------------+ > | Stefan Siegel | > | Kurt-Schumacher-Str. 34 / App. 144 | > | D-67663 Kaiserslautern | > | Tel.: +49-631-18269 | > | | > | mailto:siegel@informatik.uni-kl.de | > | PGP Public Key: | > | finger s_siegel@mikado.informatik.uni-kl.de | > +----------------------------------------------+ >=20 ------_=_NextPart_000_01BEF386.0BF3A83C Content-Type: text/plain; name="kdebase-1.1.2pre3-thumbnail.patch" Content-Disposition: attachment; filename="kdebase-1.1.2pre3-thumbnail.patch" diff -uNr kdebase/kfm/kfmman.cpp kdebase.new/kfm/kfmman.cpp --- kdebase/kfm/kfmman.cpp Thu Aug 19 17:15:01 1999 +++ kdebase.new/kfm/kfmman.cpp Fri Aug 27 20:28:06 1999 @@ -1812,11 +1812,7 @@ // At this time the icon protocol works for local files only. KMimeType *mime = KMimeType::getMagicMimeType( _url ); - if ( strcmp( mime->getMimeType(), "image/jpeg" ) == 0 || - strcmp( mime->getMimeType(), "image/gif" ) == 0 || - strcmp( mime->getMimeType(), "image/bmp" ) == 0 || - // Added bmp, because it seems to work. David. - strcmp( mime->getMimeType(), "image/x-xpm" ) == 0 ) + if ( strncmp( mime->getMimeType(), "image/", 6 ) == 0 ) { QString result; QString path(u2.path()); ------_=_NextPart_000_01BEF386.0BF3A83C Content-Type: text/plain; name="x-bmp.kdelnk" Content-Disposition: attachment; filename="x-bmp.kdelnk" # KDE Config File [KDE Desktop Entry] Type=MimeType MimeType=image/x-bmp Icon=image.xpm Patterns=*.bmp;*.BMP; Comment=bitmap image ------_=_NextPart_000_01BEF386.0BF3A83C--