[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [Fwd: bug in kioslave/http from kdebase-19990827 snapshot]
From:       Stephan Kulow <coolo () caldera ! de>
Date:       1999-08-29 10:14:33
[Download RAW message or body]

-- 
Programmers, heed this: If someone starts asking you about
agricultural genomes, it's likely time to get a handler. 
                                zdnet.com about Torvalds

Received: from master.kde.org
	by localhost with IMAP (fetchmail-5.0.4)
	for coolo@localhost (single-drop); Sun, 29 Aug 1999 11:52:53 +0200 (CEST)
Received: from wotan.itm.mu-luebeck.de ([141.83.21.121]:54195 "EHLO \
itm.mu-luebeck.de") by max.tat.physik.uni-tuebingen.de with ESMTP id \
                <S805083AbPH2BZo>; Sun, 29 Aug 1999 03:25:44 +0200
Received: from alpha.tat.physik.uni-tuebingen.de (alpha.tat.physik.uni-tuebingen.de \
[134.2.170.97])  by itm.mu-luebeck.de (8.9.1/8.9.1) with ESMTP id DAA08452
	for <coolo@itm.mu-luebeck.de>; Sun, 29 Aug 1999 03:25:42 +0200 (MET DST)
Received: from cantva.canterbury.ac.nz ([132.181.30.3]:7954 "EHLO \
cantva.canterbury.ac.nz" ident: "NO-IDENT-SERVICE[2]") by \
alpha.tat.physik.uni-tuebingen.de with ESMTP id <47161-3613> convert rfc822-to-8bit; \
                Sun, 29 Aug 1999 01:27:09 +0200
Received: from CONVERSION-DAEMON by its.canterbury.ac.nz (PMDF V5.2-32 #39167)
 id <01JFCALALZB49BWS0U@its.canterbury.ac.nz> for coolo@kde.org; Sun,
 29 Aug 1999 13:25:17 +1200 (NEW ZEALAND STANDARD TIME)
Received: from andromeda.elec.canterbury.ac.nz
 (andromeda.elec.canterbury.ac.nz [132.181.50.31])
 by its.canterbury.ac.nz (PMDF V5.2-32 #39167)
 with ESMTP id <01JFCALAAEZK9BWRVT@its.canterbury.ac.nz> for coolo@kde.org;
 Sun, 29 Aug 1999 13:25:17 +1200 (NEW ZEALAND STANDARD TIME)
Received: from avalon (skeltobc@avalon.elec.canterbury.ac.nz [132.181.52.90])
 by andromeda.elec.canterbury.ac.nz (8.9.3/8.9.3) with SMTP id NAA23628	for
 <coolo@kde.org>; Sun, 29 Aug 1999 13:25:07 +1200 (NZST)
Date:	Sun, 29 Aug 1999 13:25:25 +1200
From:	Ben Skelton <skeltobc@elec.canterbury.ac.nz>
Subject: bug in kioslave/http from kdebase-19990827 snapshot
To:	coolo@kde.org
Reply-to: skeltobc@elec.canterbury.ac.nz
Message-id: <99082913335500.32170@avalon>
MIME-version: 1.0
X-Mailer: KMail [version 1.0.21]
Content-type: text/plain
Content-transfer-encoding: 8BIT
Return-Path: <skeltobc@elec.canterbury.ac.nz>
X-Orcpt: rfc822;coolo@kde.org
X-Envid: 01JFCALAM6JM9BWS0U@its.canterbury.ac.nz
X-Mozilla-Status2: 00000000


Hi Coolo, was messing around with the snapshots and....

snapshot: kdebase-19990827

problem: my proxy authorization does not work if the header has an empty line
between the virtual host line and the proxy authorization line.

in: kioslave/http/http.cc: HTTPProtocol::http_open (around line 590)

  header += "Host: "; /* support for virtual hosts and required by HTTP 1.1 */
  header += _url.host();
  if (_url.port() != 0) {
    memset(c_buffer, 0, 64);
    sprintf(c_buffer, ":%u", port);
    header += c_buffer;
  }

  // **************************************************************************
  // THE OFFENDING LINE IS HERE
  // header += "\r\n";
  // **************************************************************************

  if (_post_data_size > 0 ) {
    header += "Content-Type: application/x-www-form-urlencoded\r\nContent-Length: ";
    memset(c_buffer, 0, 64);
    sprintf(c_buffer, "%i\r\n", _post_data_size);
    header += c_buffer;
  }

--Ben



[prev in list] [next in list] [prev in thread] [next in thread]