[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kimgio - xv-thumbnail-support - small, but significant improvement
From:       Matt Koss <koss () napri ! sk>
Date:       1999-03-23 21:19:08
[Download RAW message or body]

On Ut, 23 mar 1999, Torben Weis wrote:
>>Hi,
>
>this looks like a solution to a stone old problem of my thumbnail code.
>
>Could anybody test it and apply it if it works ?
>
>I have no running konqueror here right now :-((
>
>Bye
>Torben
>
>
>---------- Forwarded message ----------
>Date: Tue, 23 Mar 1999 13:48:27 +0100
>From: Oliver Eiden <o.eiden@pop.ruhr.de>
>To: weis@kde.org,
>    taj@kde.org
>Subject: kimgio - xv-thumbnail-support - small, but significant improvement
>Resent-Date: Tue, 23 Mar 1999 16:07:21 +0000
>Resent-From: weis@stud.uni-frankfurt.de
>Resent-To: weis@troll.no
>
>Hi kimgio team !
>
>I was wondering why thumbnails generated by xv doesn't look as nice when they are displayed in kfm
>(or other KDE-Application) compared to xv. I have compared the source of xv and kimgio/xview.cpp for
>loading thumbnails.
>
>Kimgio decodes thumbnails differently to xv when loading and xv does it "better".
>
>The problem is that in xview.cpp the 3-3-2 bits (rgb) aren't mapped "correctly" to 8-8-8 bits (rgb).
>Kimgio just doesn't use the complete available color space. This lead to a "darker"/"murkier"
>display.
>
>For example the byte 0xFF (7-7-3) (rgb) should represents white, when saved in a xvthumnnails, but
>in the current implemtation kimigio mapps 0xFF to 7<<5=224=0xE0, 7<<5=224=0xE0, 3<<6=192=0xCO, but
>it should map 0xFF to 0xFF 0xFF 0xFF.
>
>Below I have included an improved version of kimgio/xview.cpp. It is based on the kde-1.1 version.
>It is just slightly modified, but the result is significantly "visually" better. Please let me know,
>if you will include it in a next kde-release.
>
>If you are not the right people to send those "patches" please let me know, where I should sent it
>instead. 
>
>BTW: This doen't increase the quality of kfm-generated thumbnails, because before saving them via
>kimgio, they should be dithered with the correct color-table.

That's a pity. At first I thought that you have solved this problem too.
Do you have any idea how this could be solved ?

Actually I don't see any big difference in display of xv-generated
thumbnails in kfm or xv.

On the other hand, there is a BIG difference in quality of kfm-generated and
xv-generated thumbnails.
That's the reason why I still use xv for displaying picture directories.
Oh, and also because of the Update button in visual schnauzer.
I wonder why reload button in kfm doesn't also update icons when the file
size of the picture file changed.


Regards

		Matt
>
>
>Have a nice day !
>
>Oliver
>

["xview.cpp" (TEXT/PLAIN)]


--
Matej Koss	e-mail: koss@napri.sk
Kosice		ICQ#  : 19344305
Slovaki


[prev in list] [next in list] [prev in thread] [next in thread]