[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Another kfm fix, for FTP protocol
From:       David Faure <David.Faure () insa-lyon ! fr>
Date:       1999-01-26 10:39:13
[Download RAW message or body]

On Tue, Jan 26, 1999 at 11:07:37AM +0100, Waldo Bastian wrote:
> David Faure wrote:
> > The attached patch fixes it.
> > Please test it, I think it's an important fix that I would like 
> > to see in 1.1
> 
> Would it be feasible to add a test to the size response to see if
> the response was indeed 213? 
Don't forget that there is already a check for the code starting with '2'.
All the error handling can be done with the first digit of the error code
(we do that in kfm, and I just read it from the RFC).

> It's unlikely that we get another response with a number behind it,
> so size will probably be 0 anyway but the code will be more
> maintainable if such assumptions are explicitly coded in.
If we get an error (no such file, size command unknown, ...) the code will
start with a '3' or a '5' and the SIZE command will fail.

-- 
 ____________________________________________________________________
|                                                                    |
|  David FAURE                                                       |
|  E-mail : David.Faure@insa-lyon.fr, faure@kde.org                  |
|  http://www.insa-lyon.fr/People/AEDI/dfaure/index.html             |
|____________________________________________________________________|

[prev in list] [next in list] [prev in thread] [next in thread]