[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    kfm fix, please test
From:       David Faure <David.Faure () insa-lyon ! fr>
Date:       1999-01-25 21:00:25
[Download RAW message or body]

Due to the freeze, I would want developers to test the following before I
commit it :
* associate an application to either 'allfiles' or 'application/x-kdelnk'
* try to use the binding on a FSDevice kdelnk, selecting it in the RMB
popup menu -> it displays 'unknown binding'.

The following patch fixes it, but it would be good to test that it doesn't
break anything else (with .kdelnk file bindings - it don't see how it could
affect anything else) :

Index: kbind.cpp
===================================================================
RCS file: /home/kde/kdebase/kfm/kbind.cpp,v
retrieving revision 1.97
diff -u -p -r1.97 kbind.cpp
--- kbind.cpp	1999/01/25 11:23:10	1.97
+++ kbind.cpp	1999/01/25 20:50:06
@@ -2067,15 +2067,6 @@ bool KDELnkMimeType::runBinding( const c
 		    return TRUE;
 		}
 	    }
-	    else
-	    {
- 		QString tmp;
-		tmp.sprintf( "%s %s", i18n( "Unknown binding" ), _binding );
-		QMessageBox::warning( 0, i18n( "KFM Error" ), tmp );
-		// Say: Yes we have done the job. That is not quite right, but
-		// we want to stop this here, before KFM tries some stupid things :-)
-		return TRUE;
-	    }
 	}    
     }
     


If there are confirmation that this patch is needed, I'll commit it.

-- 
 ____________________________________________________________________
|                                                                    |
|  David FAURE                                                       |
|  E-mail : David.Faure@insa-lyon.fr, faure@kde.org                  |
|  http://www.insa-lyon.fr/People/AEDI/dfaure/index.html             |
|____________________________________________________________________|

[prev in list] [next in list] [prev in thread] [next in thread]