[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: bug in khtmlw
From:       Martin Jones <mjones () powerup ! com ! au>
Date:       1997-07-31 8:13:20
[Download RAW message or body]

Stephan Kulow wrote:
> 
> Martin Jones wrote:
> >
> > weis@stud.uni-frankfurt.de wrote:
> > >
> > > This is my fault. Sorry :-)
> > >
> >
> > There is nothing wrong with if ( !url.isNull() && url[0] != 0 )
> > but if ( !url.isEmpty() ) is shorter and does the same thing :-)
> >
> Are you sure, that it works? You must know, since days now, I run kfm
> only in a gdb session and a SIGSEV stoped kfm exactly in this line.
> Since the url object is defined, it could only be the reference to the
> data, that is missing. I don't want to blame somebody ;), but I think,
> this should be discussed, so we can learn for the next time!
> 
> BTW: I've tried yesterday to add working references to kfm. I think, it
> works now, but I needed hours for this, since the code of kfm is not
> very
> well documented and the khtmlw is also not very understandable for me.
> kdehelp is using KHTMLWidget (the README recommend this), but kfm uses
> KHTMLView, because (I found this in CHANGES), the view cares about
> frames.
> So I think, my anchor patch works only for single frame documents, since
> I
> added only a
> bool KHTMLView::gotoAnchor(const char* anchor)
> {
>    return view->gotoAnchor(anchor);
> }
> in KHTMLView. This works, but I couldn't find out, which frame this view
> (a KHTMLWidget) is. So I really expect troubles with frames, but I
> hadn't
> the time to find this out yesterday.
> 
> I will try some stuff today, but if you have tips for me, I would like
> to
> hear some.
> 
> kfm works now with different http-ports than 80, is updated for the  new
> toolbars and I removed this dot file problem (that I introduced :-( ).
> For today I planed some Kconfig code to get rid of the problem, that kfm
> looses the settings. I hope, I will not introduce to many new bugs.
> 
> Martin: I would like to have a (little) thing for KHTMLWidget: Could you
> please add some little spaces in the beginning and in the end of the
> page.
> Some pages look really stupid with this borderless HTML. For example
> look
> at the "last updated" line on the KDE page.
> 

Ok, I'll add a 10 pixel top and bottom border.

-- 
bye,
Martin Jones
mjones@kde.org

[prev in list] [next in list] [prev in thread] [next in thread]