[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: bug in khtmlw
From:       Martin Jones <mjones () powerup ! com ! au>
Date:       1997-07-30 19:49:14
[Download RAW message or body]

weis@stud.uni-frankfurt.de wrote:
> 
> Hi,
> 
> On Tue, 29 Jul 1997, Martin Jones wrote:
> 
> > Stephan Kulow wrote:
> > >
> > > Hi!
> > >
> > > I found a bug within the new selection code a little bug, that caused
> > > me a segfault with drag 'n drop.
> > > BTW: It seems, the kfm has some problems with the selecting. If I click
> > > on one file, I get almost every time more then this one.
> > >
> > > OK, here's what fixed the problem for me:
> > >
> > > Index: htmlobj.cpp
> > > ===================================================================
> > > RCS file: /usr/local/cvsroot/kdelibs/khtmlw/htmlobj.cpp,v
> > > retrieving revision 1.11
> > > diff -r1.11 htmlobj.cpp
> > > 72c72
> > > <     if ( isSelected() && url[0] != 0 )
> > > ---
> > > >     if ( isSelected() && !url.isNull() )
> >
> > I've seen similar code in several places in khtmlw.  I've changed some
> > of them from (for example):
> >
> >  if ( !url.isNull() && url[0] != 0 )
> >
> > to:
> >
> >  if ( !url.isEmpty() )
> 
> This is my fault. Sorry :-)
> 
> Bye
> Torben
> 

There is nothing wrong with if ( !url.isNull() && url[0] != 0 )
but if ( !url.isEmpty() ) is shorter and does the same thing :-)

-- 
bye,
Martin Jones
mjones@kde.org

[prev in list] [next in list] [prev in thread] [next in thread]