[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Review Request 127951: Don't allow opening the terminal if shell_access Kiosk mode is set
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-05-18 1:08:27
Message-ID: 20160518010827.6629.42815 () mimi ! kde ! org
[Download RAW message or body]

--===============0914990782239624945==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127951/
-----------------------------------------------------------

Review request for Dolphin and Kai Uwe Broulik.


Repository: dolphin


Description
-------

Don't allow opening the terminal if shell_access Kiosk mode is set

DolphinPart already did this. Dolphin itself didn't have this feature.


Diffs
-----

  src/dolphinmainwindow.cpp d4f2b06e75075b69ade4a40b59721d6ea818ffea 
  src/dolphinpart.cpp 01fe207f30909f02d9abab8f94c80dd52273db1c 

Diff: https://git.reviewboard.kde.org/r/127951/diff/


Testing
-------

Set 

/etc/kde5rc to:

[KDE Action Restrictions][$i]
shell_access=false
action/shell_access=false


could no longer open konsole


Thanks,

David Edmundson


--===============0914990782239624945==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127951/">https://git.reviewboard.kde.org/r/127951/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin and Kai Uwe Broulik.</div>
<div>By David Edmundson.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't allow opening the terminal if shell_access Kiosk \
mode is set</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DolphinPart already did this. Dolphin itself didn't \
have this feature.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Set </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">/etc/kde5rc to:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[KDE Action Restrictions][$i] shell_access=false
action/shell_access=false</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">could no longer open konsole</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dolphinmainwindow.cpp <span style="color: \
grey">(d4f2b06e75075b69ade4a40b59721d6ea818ffea)</span></li>

 <li>src/dolphinpart.cpp <span style="color: \
grey">(01fe207f30909f02d9abab8f94c80dd52273db1c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127951/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0914990782239624945==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic