[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 127930: Fix crash when closing split view with ownCloud plugin loaded
From: Olivier Goffart <ogoffart () kde ! org>
Date: 2016-05-17 19:34:25
Message-ID: 20160517193425.6629.8362 () mimi ! kde ! org
[Download RAW message or body]
--===============6454978180503518691==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127930/#review95554
-----------------------------------------------------------
Ship it!
Thank you!
- Olivier Goffart
On May 17, 2016, 2:47 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127930/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 2:47 p.m.)
>
>
> Review request for Dolphin, Emmanuel Pescosta, Michael Pyne, and Olivier Goffart.
>
>
> Bugs: 357479
> https://bugs.kde.org/show_bug.cgi?id=357479
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> KPluginLoader::instantiatePlugins() wraps QPluginLoader::instance(),
> which doesn't return a new object for each call, so if we set the
> KFileItemModelRolesUpdater instance as parent to the plugin the shared
> instance will be deleted leading to crashes when other instances of
> KFileItemModelRolesUpdater tries to use their plugin objects.
>
> To fix this, set the QApplication as a parent.
>
> BUG: 357479
>
>
> Diffs
> -----
>
> src/kitemviews/kfileitemmodelrolesupdater.cpp e5353dc
>
> Diff: https://git.reviewboard.kde.org/r/127930/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============6454978180503518691==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127930/">https://git.reviewboard.kde.org/r/127930/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank \
you!</p></pre> <br />
<p>- Olivier Goffart</p>
<br />
<p>On May 17th, 2016, 2:47 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin, Emmanuel Pescosta, Michael Pyne, and Olivier \
Goffart.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated May 17, 2016, 2:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=357479">357479</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KPluginLoader::instantiatePlugins() wraps \
QPluginLoader::instance(), which doesn't return a new object for each call, so if we \
set the KFileItemModelRolesUpdater instance as parent to the plugin the shared
instance will be deleted leading to crashes when other instances of
KFileItemModelRolesUpdater tries to use their plugin objects.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To fix this, set the QApplication as a parent.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">BUG: 357479</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kitemviews/kfileitemmodelrolesupdater.cpp <span style="color: \
grey">(e5353dc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127930/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6454978180503518691==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic