[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 107016: Make Find a toggle action
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2015-07-11 20:24:50
Message-ID: 20150711202450.16549.11746 () mimi ! kde ! org
[Download RAW message or body]
--===============6176338327846462215==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On oct. 24, 2012, 9:21 a.m., Frank Reininghaus wrote:
> > Thanks for the patch and the comments! I think that consistency with other KDE \
> > apps is indeed important. Discussing this with usability people sounds like a \
> > good idea to me.
>
> Kai Uwe Broulik wrote:
> Well, imho the Find features in the editor, browsers, etc are finding for contents \
> inside a document, and where you are likely to leave it open for a while and do \
> additional searches and everything, whereas I think in Dolphin you open it, look \
> for something, and close it. Also, and more importantly, Dolphin is one of the few \
> applications that specifically announce the Search features in the toolbar by \
> default, none of the other apps do this. So I think it should be a toggle button, \
> since you have that button in the toolbar by default. (Dolphin doesn't use the \
> standard places bar, so much for consistency scnr *duck* :P)
> Àlex Fiestas wrote:
> I will go ahead and bring the topic to the usability list now that master is open \
> again.
> Emmanuel Pescosta wrote:
> Alex, any updates or should we discard this request?
https://forum.kde.org/viewtopic.php?f=285&t=127215 Opened a thread on the topic.
- Àlex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107016/#review20777
-----------------------------------------------------------
On oct. 23, 2012, 10:07 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/107016/
> -----------------------------------------------------------
>
> (Updated oct. 23, 2012, 10:07 p.m.)
>
>
> Review request for Dolphin and Frank Osterfeld.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> I was working in the placesview when I noticed that the Find is not a toggle \
> button. Pushing many times the Find button resulted in "nothing" and I expected it \
> to "disable" the search mode, as it happens with Split, or Preview.
> The patch is pretty straight forward.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 7da5801
> dolphin/src/dolphinmainwindow.cpp b4a25a7
>
> Diff: https://git.reviewboard.kde.org/r/107016/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
--===============6176338327846462215==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/107016/">https://git.reviewboard.kde.org/r/107016/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On octubre 24th, 2012, 9:21 a.m. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch and the comments! I think that consistency with \
other KDE apps is indeed important. Discussing this with usability people sounds like \
a good idea to me.</pre> </blockquote>
<p>On octubre 24th, 2012, 9:56 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, imho the Find \
features in the editor, browsers, etc are finding for contents inside a document, and \
where you are likely to leave it open for a while and do additional searches and \
everything, whereas I think in Dolphin you open it, look for something, and close it. \
Also, and more importantly, Dolphin is one of the few applications that specifically \
announce the Search features in the toolbar by default, none of the other apps do \
this. So I think it should be a toggle button, since you have that button in the \
toolbar by default. (Dolphin doesn't use the standard places bar, so much for \
consistency scnr *duck* :P)</pre> </blockquote>
<p>On gener 7th, 2013, 3:50 p.m. UTC, <b>Àlex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will go ahead and \
bring the topic to the usability list now that master is open again.</pre> \
</blockquote>
<p>On setembre 8th, 2014, 11:22 a.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Alex, \
any updates or should we discard this request?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://forum.kde.org/viewtopic.php?f=285&t=127215 Opened a thread on \
the topic.</p></pre> <br />
<p>- Àlex</p>
<br />
<p>On octubre 23rd, 2012, 10:07 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Frank Osterfeld.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated oct. 23, 2012, 10:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was working in the placesview when I noticed that the Find is not a \
toggle button. Pushing many times the Find button resulted in "nothing" and \
I expected it to "disable" the search mode, as it happens with Split, or \
Preview.
The patch is pretty straight forward.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(b4a25a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/107016/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6176338327846462215==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic