--===============6176338327846462215== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On oct. 24, 2012, 9:21 a.m., Frank Reininghaus wrote: > > Thanks for the patch and the comments! I think that consistency with other KDE apps is indeed important. Discussing this with usability people sounds like a good idea to me. > > Kai Uwe Broulik wrote: > Well, imho the Find features in the editor, browsers, etc are finding for contents inside a document, and where you are likely to leave it open for a while and do additional searches and everything, whereas I think in Dolphin you open it, look for something, and close it. Also, and more importantly, Dolphin is one of the few applications that specifically announce the Search features in the toolbar by default, none of the other apps do this. So I think it should be a toggle button, since you have that button in the toolbar by default. > (Dolphin doesn't use the standard places bar, so much for consistency scnr *duck* :P) > > Àlex Fiestas wrote: > I will go ahead and bring the topic to the usability list now that master is open again. > > Emmanuel Pescosta wrote: > Alex, any updates or should we discard this request? https://forum.kde.org/viewtopic.php?f=285&t=127215 Opened a thread on the topic. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107016/#review20777 ----------------------------------------------------------- On oct. 23, 2012, 10:07 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/107016/ > ----------------------------------------------------------- > > (Updated oct. 23, 2012, 10:07 p.m.) > > > Review request for Dolphin and Frank Osterfeld. > > > Repository: kde-baseapps > > > Description > ------- > > I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview. > > The patch is pretty straight forward. > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h 7da5801 > dolphin/src/dolphinmainwindow.cpp b4a25a7 > > Diff: https://git.reviewboard.kde.org/r/107016/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > > --===============6176338327846462215== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107016/

On octubre 24th, 2012, 9:21 a.m. UTC, Frank Reininghaus wrote:

Thanks for the patch and the comments! I think that consistency with other KDE apps is indeed important. Discussing this with usability people sounds like a good idea to me.

On octubre 24th, 2012, 9:56 a.m. UTC, Kai Uwe Broulik wrote:

Well, imho the Find features in the editor, browsers, etc are finding for contents inside a document, and where you are likely to leave it open for a while and do additional searches and everything, whereas I think in Dolphin you open it, look for something, and close it. Also, and more importantly, Dolphin is one of the few applications that specifically announce the Search features in the toolbar by default, none of the other apps do this. So I think it should be a toggle button, since you have that button in the toolbar by default. 
(Dolphin doesn't use the standard places bar, so much for consistency scnr *duck* :P)

On gener 7th, 2013, 3:50 p.m. UTC, Àlex Fiestas wrote:

I will go ahead and bring the topic to the usability list now that master is open again.

On setembre 8th, 2014, 11:22 a.m. UTC, Emmanuel Pescosta wrote:

Alex, any updates or should we discard this request?
https://forum.kde.org/viewtopic.php?f=285&t=127215 Opened a thread on the topic.

- Àlex


On octubre 23rd, 2012, 10:07 p.m. UTC, Àlex Fiestas wrote:

Review request for Dolphin and Frank Osterfeld.
By Àlex Fiestas.

Updated oct. 23, 2012, 10:07 p.m.

Repository: kde-baseapps

Description 

I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview.

The patch is pretty straight forward.

Diffs

  • dolphin/src/dolphinmainwindow.h (7da5801)
  • dolphin/src/dolphinmainwindow.cpp (b4a25a7)

View Diff
--===============6176338327846462215==--