[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 120171: Add option to allow execution as well as opening of scripts and desktop f
From: "Arjun Ak" <arjunak234 () gmail ! com>
Date: 2014-09-15 20:37:37
Message-ID: 20140915203737.22584.80298 () probe ! kde ! org
[Download RAW message or body]
--===============5060263146267020093==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120171/
-----------------------------------------------------------
(Updated Sept. 16, 2014, 2:07 a.m.)
Review request for Dolphin and David Faure.
Changes
-------
Fixed mentiond issues.
Bugs: 275405
http://bugs.kde.org/show_bug.cgi?id=275405
Repository: kde-baseapps
Description
-------
This patch allows the user to execute (in background, within the embedded terminal, \
external terminal) or open an executable file (scripts, desktop files...). When the \
user clicks on an executable file, a \
[dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png) \
pops up which contains options to either open it or execute it. Clicking on execute \
runs the program in the background (dolphin's current behaviour).
The [settings dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png) \
has further options to fine-tune how the file is executed. The program can either be \
executed in the background or inside the embedded konsole or in an external terminal.
In case there is a process already running in the embedded terminal, with [user's \
permission](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png) \
it will be terminated and the selected program will be started.
See also:
https://git.reviewboard.kde.org/r/118939/
Diffs (updated)
-----
dolphin/src/dolphinviewcontainer.h 31612f1
dolphin/src/dolphinviewcontainer.cpp a11ba42
dolphin/src/panels/terminal/terminalpanel.h 374476e
dolphin/src/panels/terminal/terminalpanel.cpp bfd3002
dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7
dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0
dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d
dolphin/src/CMakeLists.txt 6f256a2
dolphin/src/dolphinmainwindow.h 9d4c003
dolphin/src/dolphinmainwindow.cpp 95b08af
Diff: https://git.reviewboard.kde.org/r/120171/diff/
Testing
-------
File Attachments
----------------
Dialog
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png
settings
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png
Replace current program
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png
Thanks,
Arjun Ak
--===============5060263146267020093==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120171/">https://git.reviewboard.kde.org/r/120171/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and David Faure.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2014, 2:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed mentiond issues.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=275405">275405</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch allows the user to execute (in background, \
within the embedded terminal, external terminal) or open an executable file (scripts, \
desktop files...). When the user clicks on an executable file, a <a \
href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">dialog</a> pops up which contains options to either open it or execute it. \
Clicking on execute runs the program in the background (dolphin's current \
behaviour).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The <a \
href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">settings dialog</a> has further options to fine-tune how the file is \
executed. The program can either be executed in the background or inside the embedded \
konsole or in an external terminal.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In case there is a \
process already running in the embedded terminal, with <a \
href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">user's permission</a> it will be terminated and the selected program will be \
started.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
https://git.reviewboard.kde.org/r/118939/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinviewcontainer.h <span style="color: \
grey">(31612f1)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(a11ba42)</span></li>
<li>dolphin/src/panels/terminal/terminalpanel.h <span style="color: \
grey">(374476e)</span></li>
<li>dolphin/src/panels/terminal/terminalpanel.cpp <span style="color: \
grey">(bfd3002)</span></li>
<li>dolphin/src/settings/dolphin_generalsettings.kcfg <span style="color: \
grey">(849a9c7)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.h <span style="color: \
grey">(7a9c2f0)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(cbbde1d)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(6f256a2)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(9d4c003)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(95b08af)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120171/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png">Dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png">settings</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png">Replace \
current program</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5060263146267020093==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic