[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-07-20 21:56:24
Message-ID: 20140720215624.14616.88292 () probe ! kde ! org
[Download RAW message or body]
--===============3999560458302755612==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118994/#review62753
-----------------------------------------------------------
Ship it!
Thank you very much for working on this, Arjun, and thanks also for your very good \
suggestions, Emmanuel!
I apologize for not responding earlier. I was a bit busy at work recently and did not \
really find the time to check all mails and review request notifications in my inbox \
and see which of them could (and should) be handled quickly nevertheless (like this \
one).
Looks very good from my point of view. Please go ahead and push it. I have one minor \
suggestion for a change, but feel free to ignore it if you prefer, it's probably a \
matter of taste.
Thanks again for adding a useful feature, which many users will appreciate.
dolphin/src/dolphinmainwindow.cpp
<https://git.reviewboard.kde.org/r/118994/#comment43499>
I would prefer setEnabled(count > 0) (because it makes it clear at first sight \
that the argument is a bool), but that might be a matter of taste.
- Frank Reininghaus
On July 6, 2014, 1:58 p.m., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118994/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 1:58 p.m.)
>
>
> Review request for Dolphin and KDE Base Apps.
>
>
> Bugs: 336818
> http://bugs.kde.org/show_bug.cgi?id=336818
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help \
> of Go->'Recently closed tabs' menu).
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 7c3bff4
> dolphin/src/dolphinmainwindow.cpp d9fe645
> dolphin/src/dolphinrecenttabsmenu.h 34d4153
> dolphin/src/dolphinrecenttabsmenu.cpp a39f994
> dolphin/src/dolphinui.rc 52826bb
>
> Diff: https://git.reviewboard.kde.org/r/118994/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
--===============3999560458302755612==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118994/">https://git.reviewboard.kde.org/r/118994/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank \
you very much for working on this, Arjun, and thanks also for your very good \
suggestions, Emmanuel!</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I apologize for not responding earlier. \
I was a bit busy at work recently and did not really find the time to check all mails \
and review request notifications in my inbox and see which of them could (and should) \
be handled quickly nevertheless (like this one).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
very good from my point of view. Please go ahead and push it. I have one minor \
suggestion for a change, but feel free to ignore it if you prefer, it's probably a \
matter of taste.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Thanks again for adding a useful \
feature, which many users will appreciate.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118994/diff/7/?file=287781#file287781line1267" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphinmainwindow.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1267</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">action</span><span class="p">(</span><span \
class="s">"undo_close_tab"</span><span class="p">)</span><span \
class="o">-></span><span class="n">setEnabled</span><span class="p">(</span><span \
class="n">count</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would prefer setEnabled(count > 0) (because it makes it clear at first sight that \
the argument is a bool), but that might be a matter of taste.</p></pre> </div>
</div>
<br />
<p>- Frank Reininghaus</p>
<br />
<p>On July 6th, 2014, 1:58 p.m. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated July 6, 2014, 1:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336818">336818</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Upon pressing CTRL+SHIFT+T, the most recently closed \
tab is reopened (with the help of Go->'Recently closed tabs' menu).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7c3bff4)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(d9fe645)</span></li>
<li>dolphin/src/dolphinrecenttabsmenu.h <span style="color: \
grey">(34d4153)</span></li>
<li>dolphin/src/dolphinrecenttabsmenu.cpp <span style="color: \
grey">(a39f994)</span></li>
<li>dolphin/src/dolphinui.rc <span style="color: grey">(52826bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118994/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3999560458302755612==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic