From kfm-devel Sun Jul 20 21:56:24 2014 From: "Frank Reininghaus" Date: Sun, 20 Jul 2014 21:56:24 +0000 To: kfm-devel Subject: Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab Message-Id: <20140720215624.14616.88292 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=140589343705498 --===============3999560458302755612== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review62753 ----------------------------------------------------------- Ship it! Thank you very much for working on this, Arjun, and thanks also for your very good suggestions, Emmanuel! I apologize for not responding earlier. I was a bit busy at work recently and did not really find the time to check all mails and review request notifications in my inbox and see which of them could (and should) be handled quickly nevertheless (like this one). Looks very good from my point of view. Please go ahead and push it. I have one minor suggestion for a change, but feel free to ignore it if you prefer, it's probably a matter of taste. Thanks again for adding a useful feature, which many users will appreciate. dolphin/src/dolphinmainwindow.cpp I would prefer setEnabled(count > 0) (because it makes it clear at first sight that the argument is a bool), but that might be a matter of taste. - Frank Reininghaus On July 6, 2014, 1:58 p.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118994/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 1:58 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Bugs: 336818 > http://bugs.kde.org/show_bug.cgi?id=336818 > > > Repository: kde-baseapps > > > Description > ------- > > Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of Go->'Recently closed tabs' menu). > > > Diffs > ----- > > dolphin/src/dolphinmainwindow.h 7c3bff4 > dolphin/src/dolphinmainwindow.cpp d9fe645 > dolphin/src/dolphinrecenttabsmenu.h 34d4153 > dolphin/src/dolphinrecenttabsmenu.cpp a39f994 > dolphin/src/dolphinui.rc 52826bb > > Diff: https://git.reviewboard.kde.org/r/118994/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > > --===============3999560458302755612== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/

Ship it!

Thank you very much for working on this, Arjun, and thanks also for your very good suggestions, Emmanuel!

I apologize for not responding earlier. I was a bit busy at work recently and did not really find the time to check all mails and review request notifications in my inbox and see which of them could (and should) be handled quickly nevertheless (like this one).

Looks very good from my point of view. Please go ahead and push it. I have one minor suggestion for a change, but feel free to ignore it if you prefer, it's probably a matter of taste.

Thanks again for adding a useful feature, which many users will appreciate.

dolphin/src/dolphinmainwindow.cpp (Diff revision 7)
		1267	actionCollection()->action("undo_close_tab")->setEnabled(count);

I would prefer setEnabled(count > 0) (because it makes it clear at first sight that the argument is a bool), but that might be a matter of taste.

- Frank Reininghaus

On July 6th, 2014, 1:58 p.m. UTC, Arjun Ak wrote:

Review request for Dolphin and KDE Base Apps.

By Arjun Ak.

Updated July 6, 2014, 1:58 p.m.

Bugs: 336818

Repository: kde-baseapps

Description

Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of Go->'Recently closed tabs' menu).

Diffs

dolphin/src/dolphinmainwindow.h (7c3bff4)
dolphin/src/dolphinmainwindow.cpp (d9fe645)
dolphin/src/dolphinrecenttabsmenu.h (34d4153)
dolphin/src/dolphinrecenttabsmenu.cpp (a39f994)
dolphin/src/dolphinui.rc (52826bb)

--===============3999560458302755612==--