[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 106827: Fix Bug 304643 - selected place looks ugly and incomplete
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-02-05 15:39:02
Message-ID: 20140205153902.28358.85033 () probe ! kde ! org
[Download RAW message or body]
> On June 5, 2013, 8:02 p.m., Frank Reininghaus wrote:
> > Just for the record, I have not completely forgotton about this issue, even \
> > though I never said anything about it recently. It's just that there are always \
> > so many incoming bug reports, emails, and other things, and only very little time \
> > to handle all this.
> > I am convinced now that the tinting is really a stupid idea, and now that the \
> > FolderView people have copied it, I think it's time to change it. I had this in \
> > mind on my "Things that should be looked into at least before the 4.11 RCs" list \
> > already.
> > I think the best approach would be just go back to the Dolpin 1.x behaviour \
> > (equal to the file dialog), not tint the icons/previews, and draw a blue \
> > rectangle around the selected item. Nuno's idea sounds also interesting, but \
> > maybe this is something to consider for the frameworks era - I think that we \
> > should not go too far away from the file dialog design just now.
> "Things that should be looked into at least before the 4.11 RCs"
Maybe something for 4.13? ;)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106827/#review33817
-----------------------------------------------------------
On June 4, 2013, 6:39 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 6:39 p.m.)
>
>
> Review request for Dolphin, Nuno Bento and Frank Reininghaus.
>
>
> Bugs: 304643
> http://bugs.kde.org/show_bug.cgi?id=304643
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Fix Bug 304643 - selected place looks ugly and incomplete
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistwidget.h 55181fa
> dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a
> dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf
> dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b
> dolphin/src/panels/places/placesitemlistwidget.h a2a88c1
> dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da
>
> Diff: https://git.reviewboard.kde.org/r/106827/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Old and new Dolphin Places look
> https://git.reviewboard.kde.org/r/106827/s/779/
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/106827/">https://git.reviewboard.kde.org/r/106827/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 5th, 2013, 8:02 p.m. CEST, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just for the record, I have not completely forgotton about this issue, \
even though I never said anything about it recently. It's just that there are \
always so many incoming bug reports, emails, and other things, and only very little \
time to handle all this.
I am convinced now that the tinting is really a stupid idea, and now that the \
FolderView people have copied it, I think it's time to change it. I had this in \
mind on my "Things that should be looked into at least before the 4.11 RCs" \
list already.
I think the best approach would be just go back to the Dolpin 1.x behaviour (equal to \
the file dialog), not tint the icons/previews, and draw a blue rectangle around the \
selected item. Nuno's idea sounds also interesting, but maybe this is something \
to consider for the frameworks era - I think that we should not go too far away from \
the file dialog design just now.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> "Things that \
should be looked into at least before the 4.11 RCs" Maybe something for 4.13? \
;)</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On June 4th, 2013, 6:39 p.m. CEST, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, Nuno Bento and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated June 4, 2013, 6:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304643">304643</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Bug 304643 - selected place looks ugly and incomplete</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistwidget.h <span style="color: \
grey">(55181fa)</span></li>
<li>dolphin/src/kitemviews/kitemlistwidget.cpp <span style="color: \
grey">(6a7111a)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.h <span style="color: \
grey">(787722d)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: \
grey">(72d10cf)</span></li>
<li>dolphin/src/panels/folders/foldersitemlistwidget.cpp <span style="color: \
grey">(b4f9a5b)</span></li>
<li>dolphin/src/panels/places/placesitemlistwidget.h <span style="color: \
grey">(a2a88c1)</span></li>
<li>dolphin/src/panels/places/placesitemlistwidget.cpp <span style="color: \
grey">(e33d1da)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/106827/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="https://git.reviewboard.kde.org/r/106827/s/779/"><img \
src="https://git.reviewboard.kde.org/media/uploaded/images/2012/10/15/dolphin_places_400x100.png" \
style="border: 1px black solid;" alt="Old and new Dolphin Places look" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic