[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 112577: Created DolphinViewSignalAdapter class to get rid of DolphinMainWindow::c
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2014-02-05 14:32:22
Message-ID: 20140205143222.20382.44674 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112577/
-----------------------------------------------------------
(Updated Feb. 5, 2014, 3:32 p.m.)
Status
------
This change has been discarded.
Review request for Dolphin.
Repository: kde-baseapps
Description
-------
Move the tab-handling away from DolpinMainWindow (Patch-Series)
Created DolphinViewSignalAdapter class to get rid of DolphinMainWindow::connectViewSignals().
DolphinMainWindow connects to all the signals provided by the adapter class (only once) and the
adapter class connects himself to the signals of the actual view container. When the actual
view container has been changed, the adapter class disconnects all signals to the previous
view container and connects all signals to the new view container.
One positive side effect is, that only the active view container's signals are processed
in the main window instead of all signals from all view containers.
We need this for the future tab handling code.
Diffs
-----
dolphin/src/CMakeLists.txt 48ea14c
dolphin/src/dolphinmainwindow.h 7da5801
dolphin/src/dolphinmainwindow.cpp 4128cdf
dolphin/src/dolphinviewsignaladapter.h PRE-CREATION
dolphin/src/dolphinviewsignaladapter.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/112577/diff/
Testing
-------
Signals like request context menu, ... work.
Thanks,
Emmanuel Pescosta
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112577/">https://git.reviewboard.kde.org/r/112577/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 3:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Move the tab-handling away from DolpinMainWindow (Patch-Series)
Created DolphinViewSignalAdapter class to get rid of \
DolphinMainWindow::connectViewSignals().
DolphinMainWindow connects to all the signals provided by the adapter class (only \
once) and the adapter class connects himself to the signals of the actual view \
container. When the actual view container has been changed, the adapter class \
disconnects all signals to the previous view container and connects all signals to \
the new view container.
One positive side effect is, that only the active view container's signals are \
processed in the main window instead of all signals from all view containers.
We need this for the future tab handling code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Signals like request context menu, ... work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(48ea14c)</span></li>
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(4128cdf)</span></li>
<li>dolphin/src/dolphinviewsignaladapter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/dolphinviewsignaladapter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112577/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic