[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: UDSEntry compression ideas
From:       Mark <markg85 () gmail ! com>
Date:       2013-09-22 18:08:19
Message-ID: CAPd6JnH+EipsNXnPWhccig4u3p96i8=CL7qNCgLZxAbCEOKkFQ () mail ! gmail ! com
[Download RAW message or body]

On Sun, Sep 22, 2013 at 10:36 AM, David Faure <faure@kde.org> wrote:

> On Saturday 21 September 2013 15:45:55 Mark wrote:
> > The patch: http://paste.kde.org/p2ece1fd8/
> > Besides the line you said i also changed the line above. Hence asking
> for a
> > "OK" to commit.
>
> I said "Same for the other tests for d_type, they should all use == then."
> so we agree :-)
>

Done:
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8b9f8b3082d43c4605ef78d18009b98b5997f7eb
Sorry for being extra careful.  Perhaps too careful..

>
> > Then a few questions for frameworks. How do i merge this change back in
> > frameworks?
>
> s/back/forward/ :)
> Don't.
> I regularly merge 4.11 to master and master to frameworks.
>

Awesome!

>
> > Note: i'm right now making a unittest for this specific case in
> frameworks,
> > not for 4.11. Just a general "udsentrytest" which should later be
> extended
> > to cover more of UDSEntry.
>
> OK, great. Although listing is rather part of jobtest or of your new
> listdirtest... This wasn't a UDSEntry bug, but a KIO::listDir bug (as far
> as
> the user of the API is concerned).
>

A gentle pointer to the K-F-D list where i posted this patch :)
If you could respond there?
It's title: "New test with C++11 and lambda (UDSEntry testcase)"

>
> --
> David Faure, faure@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>

[Attachment #3 (text/html)]

<div dir="ltr">On Sun, Sep 22, 2013 at 10:36 AM, David Faure <span dir="ltr">&lt;<a \
href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>&gt;</span> \
wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">



<div>On Saturday 21 September 2013 15:45:55 Mark wrote:<br>
&gt; The patch: <a href="http://paste.kde.org/p2ece1fd8/" \
target="_blank">http://paste.kde.org/p2ece1fd8/</a><br> &gt; Besides the line you \
said i also changed the line above. Hence asking for a<br> &gt; &quot;OK&quot; to \
commit.<br> <br>
</div>I said &quot;Same for the other tests for d_type, they should all use == \
then.&quot;<br> so we agree :-)<br></blockquote><div><br></div><div>Done: <a \
href="http://quickgit.kde.org/?p=kdelibs.git&amp;a=commit&amp;h=8b9f8b3082d43c4605ef78d18009b98b5997f7eb" \
target="_blank">http://quickgit.kde.org/?p=kdelibs.git&amp;a=commit&amp;h=8b9f8b3082d43c4605ef78d18009b98b5997f7eb</a></div>



<div>Sorry for being extra careful.  Perhaps too careful..</div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">




<div><br>
&gt; Then a few questions for frameworks. How do i merge this change back in<br>
&gt; frameworks?<br>
<br>
</div>s/back/forward/ :)<br>
Don&#39;t.<br>
I regularly merge 4.11 to master and master to \
frameworks.<br></blockquote><div><br></div><div>Awesome! </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">




<div><br>
&gt; Note: i&#39;m right now making a unittest for this specific case in \
frameworks,<br> &gt; not for 4.11. Just a general &quot;udsentrytest&quot; which \
should later be extended<br> &gt; to cover more of UDSEntry.<br>
<br>
</div>OK, great. Although listing is rather part of jobtest or of your new<br>
listdirtest... This wasn&#39;t a UDSEntry bug, but a KIO::listDir bug (as far as<br>
the user of the API is concerned).<br></blockquote><div><br></div><div>A gentle \
pointer to the K-F-D list where i posted this patch :) </div><div>If you could \
respond there?</div><div>It&#39;s title: &quot;New test with C++11 and lambda \
(UDSEntry testcase)&quot;</div>

<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">


<div><div><br>
--<br>
David Faure, <a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>, <a \
href="http://www.davidfaure.fr" target="_blank">http://www.davidfaure.fr</a><br> \
Working on KDE, in particular KDE Frameworks 5<br> <br>
</div></div></blockquote></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]