--047d7bdca04214195504e6fccb8e Content-Type: text/plain; charset=ISO-8859-1 On Sun, Sep 22, 2013 at 10:36 AM, David Faure wrote: > On Saturday 21 September 2013 15:45:55 Mark wrote: > > The patch: http://paste.kde.org/p2ece1fd8/ > > Besides the line you said i also changed the line above. Hence asking > for a > > "OK" to commit. > > I said "Same for the other tests for d_type, they should all use == then." > so we agree :-) > Done: http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8b9f8b3082d43c4605ef78d18009b98b5997f7eb Sorry for being extra careful. Perhaps too careful.. > > > Then a few questions for frameworks. How do i merge this change back in > > frameworks? > > s/back/forward/ :) > Don't. > I regularly merge 4.11 to master and master to frameworks. > Awesome! > > > Note: i'm right now making a unittest for this specific case in > frameworks, > > not for 4.11. Just a general "udsentrytest" which should later be > extended > > to cover more of UDSEntry. > > OK, great. Although listing is rather part of jobtest or of your new > listdirtest... This wasn't a UDSEntry bug, but a KIO::listDir bug (as far > as > the user of the API is concerned). > A gentle pointer to the K-F-D list where i posted this patch :) If you could respond there? It's title: "New test with C++11 and lambda (UDSEntry testcase)" > > -- > David Faure, faure@kde.org, http://www.davidfaure.fr > Working on KDE, in particular KDE Frameworks 5 > > --047d7bdca04214195504e6fccb8e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sun, Sep 22, 2013 at 10:36 AM, David Faure <faure@kde.org<= /a>> wrote:
On Saturday 21 September 2013 15:45:55 Mark wrote:
> The patch: http://paste.kde.org/p2ece1fd8/
> Besides the line you said i also changed the line above. Hence asking = for a
> "OK" to commit.

I said "Same for the other tests for d_type, they should all use= =3D=3D then."
so we agree :-)

Done:=A0http://quickgit.kde.org/?p=3Dk= delibs.git&a=3Dcommit&h=3D8b9f8b3082d43c4605ef78d18009b98b5997f7eb<= /a>
Sorry for being extra careful. =A0Perhaps too careful..

> Then a few questions for frameworks. How do i merge this change back i= n
> frameworks?

s/back/forward/ :)
Don't.
I regularly merge 4.11 to master and master to frameworks.
=

Awesome!=A0

> Note: i'm right now making a unittest for this specific case in fr= ameworks,
> not for 4.11. Just a general "udsentrytest" which should lat= er be extended
> to cover more of UDSEntry.

OK, great. Although listing is rather part of jobtest or of your new<= br> listdirtest... This wasn't a UDSEntry bug, but a KIO::listDir bug (as f= ar as
the user of the API is concerned).

A ge= ntle pointer to the K-F-D list where i posted this patch :)=A0
If= you could respond there?
It's title: "New test with C++= 11 and lambda (UDSEntry testcase)"

--
David Faure, faure@kde.o= rg, http://www.d= avidfaure.fr
Working on KDE, in particular KDE Frameworks 5


--047d7bdca04214195504e6fccb8e--