[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 112728: Move KItemRange to its own header, and factor out the code that transform
From: "Commit Hook" <null () kde ! org>
Date: 2013-09-16 22:15:45
Message-ID: 20130916221545.21042.98463 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112728/#review40182
-----------------------------------------------------------
This review has been submitted with commit 7dde35ccb97ac2958e45fe6b0759901e02d5e5e3 \
by Frank Reininghaus to branch master.
- Commit Hook
On Sept. 14, 2013, 3:36 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112728/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 3:36 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> There is some code duplication in KFileItemModel: We have two different \
> implementations for the transformation of a sorted QList<int> to a KItemRangeList.
> I propose to change this by factoring out this code, and moving KItemRange(List) to \
> its own header file while we're at it. It's header-only with inline functions for \
> simplicity and efficiency. Moreover, I made the function that takes the sorted list \
> a template, such that one can easily replace QList by QVector, for example.
> Note that overriding operator<<() in KItemRangeList was necessary because it's not \
> a typedef for QList<KItemRange>, but a class derived from that with my patch, and \
> some code fails to compile if the return type of that function is QList<KItemRange> \
> and not KItemRangeList.
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kfileitemmodel.cpp 51ff142
> dolphin/src/kitemviews/kitemmodelbase.h 7545192
> dolphin/src/kitemviews/kitemmodelbase.cpp c13c9f8
> dolphin/src/kitemviews/kitemrange.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112728/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112728/">http://git.reviewboard.kde.org/r/112728/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7dde35ccb97ac2958e45fe6b0759901e02d5e5e3 by Frank Reininghaus \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 14th, 2013, 3:36 p.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2013, 3:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is some code duplication in KFileItemModel: We have two different \
implementations for the transformation of a sorted QList<int> to a \
KItemRangeList.
I propose to change this by factoring out this code, and moving KItemRange(List) to \
its own header file while we're at it. It's header-only with inline functions \
for simplicity and efficiency. Moreover, I made the function that takes the sorted \
list a template, such that one can easily replace QList by QVector, for example.
Note that overriding operator<<() in KItemRangeList was necessary because \
it's not a typedef for QList<KItemRange>, but a class derived from that \
with my patch, and some code fails to compile if the return type of that function is \
QList<KItemRange> and not KItemRangeList.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(51ff142)</span></li>
<li>dolphin/src/kitemviews/kitemmodelbase.h <span style="color: \
grey">(7545192)</span></li>
<li>dolphin/src/kitemviews/kitemmodelbase.cpp <span style="color: \
grey">(c13c9f8)</span></li>
<li>dolphin/src/kitemviews/kitemrange.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112728/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic