This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112728/

This review has been submitted with commit 7dde35ccb97ac2958e45fe6b0759901e02d5e5e3 by Frank Reininghaus to branch master.

- Commit


On September 14th, 2013, 3:36 p.m. UTC, Frank Reininghaus wrote:

Review request for Dolphin.
By Frank Reininghaus.

Updated Sept. 14, 2013, 3:36 p.m.

Description

There is some code duplication in KFileItemModel: We have two different implementations for the transformation of a sorted QList<int> to a KItemRangeList.

I propose to change this by factoring out this code, and moving KItemRange(List) to its own header file while we're at it. It's header-only with inline functions for simplicity and efficiency. Moreover, I made the function that takes the sorted list a template, such that one can easily replace QList by QVector, for example.

Note that overriding operator<<() in KItemRangeList was necessary because it's not a typedef for QList<KItemRange>, but a class derived from that with my patch, and some code fails to compile if the return type of that function is QList<KItemRange> and not KItemRangeList.

Testing

Unit tests pass.

Diffs

  • dolphin/src/kitemviews/kfileitemmodel.cpp (51ff142)
  • dolphin/src/kitemviews/kitemmodelbase.h (7545192)
  • dolphin/src/kitemviews/kitemmodelbase.cpp (c13c9f8)
  • dolphin/src/kitemviews/kitemrange.h (PRE-CREATION)

View Diff