[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b5633
From: "Commit Hook" <null () kde ! org>
Date: 2012-10-28 19:12:51
Message-ID: 20121028191251.29233.7582 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107072/#review21054
-----------------------------------------------------------
This review has been submitted with commit feb7006b220a6bed0d2805eb787f5208b7bacc45 \
by Emmanuel Pescosta to branch master.
- Commit Hook
On Oct. 27, 2012, 2:05 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107072/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2012, 2:05 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b5633.
>
> * Implemented Rename-Inline-Option in Settings Dialog
> * Re-enable renaming items with the rename dialog in Folderview-Panel
>
>
> This addresses bug 306705.
> http://bugs.kde.org/show_bug.cgi?id=306705
>
>
> Diffs
> -----
>
> dolphin/src/panels/folders/folderspanel.cpp 13093ff
> dolphin/src/settings/general/behaviorsettingspage.h 3989862
> dolphin/src/settings/general/behaviorsettingspage.cpp 1ade93c
>
> Diff: http://git.reviewboard.kde.org/r/107072/diff/
>
>
> Testing
> -------
>
> Rename-Dialog works for Folderview-Panel
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107072/">http://git.reviewboard.kde.org/r/107072/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit feb7006b220a6bed0d2805eb787f5208b7bacc45 by Emmanuel Pescosta \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 27th, 2012, 2:05 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2012, 2:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Extended/Completed Frank's commit \
7ca682fe903d6abfc44e2f26878e19ddc48b5633.
* Implemented Rename-Inline-Option in Settings Dialog
* Re-enable renaming items with the rename dialog in Folderview-Panel</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rename-Dialog works for Folderview-Panel</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306705">306705</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(13093ff)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.h <span style="color: \
grey">(3989862)</span></li>
<li>dolphin/src/settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(1ade93c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107072/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic