From kfm-devel Sun Oct 28 19:12:51 2012 From: "Commit Hook" Date: Sun, 28 Oct 2012 19:12:51 +0000 To: kfm-devel Subject: Re: Review Request: Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b5633 Message-Id: <20121028191251.29233.7582 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=135145158828377 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8355860896986118375==" --===============8355860896986118375== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107072/#review21054 ----------------------------------------------------------- This review has been submitted with commit feb7006b220a6bed0d2805eb787f5208= b7bacc45 by Emmanuel Pescosta to branch master. - Commit Hook On Oct. 27, 2012, 2:05 p.m., Emmanuel Pescosta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107072/ > ----------------------------------------------------------- > = > (Updated Oct. 27, 2012, 2:05 p.m.) > = > = > Review request for Dolphin and Frank Reininghaus. > = > = > Description > ------- > = > Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b563= 3. > = > * Implemented Rename-Inline-Option in Settings Dialog > * Re-enable renaming items with the rename dialog in Folderview-Panel > = > = > This addresses bug 306705. > http://bugs.kde.org/show_bug.cgi?id=3D306705 > = > = > Diffs > ----- > = > dolphin/src/panels/folders/folderspanel.cpp 13093ff = > dolphin/src/settings/general/behaviorsettingspage.h 3989862 = > dolphin/src/settings/general/behaviorsettingspage.cpp 1ade93c = > = > Diff: http://git.reviewboard.kde.org/r/107072/diff/ > = > = > Testing > ------- > = > Rename-Dialog works for Folderview-Panel > = > = > Thanks, > = > Emmanuel Pescosta > = > --===============8355860896986118375== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107072/ 

This revie=
w has been submitted with commit feb7006b220a6bed0d2805eb787f5208b7bacc45 b=
y Emmanuel Pescosta to branch master.

- Commit


On October 27th, 2012, 2:05 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin and Frank Reininghaus.
By Emmanuel Pescosta.

Updated Oct. 27, 2012, 2:05 p.m.

Descripti= on 

Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f=
26878e19ddc48b5633.

* Implemented Rename-Inline-Option in Settings Dialog
* Re-enable renaming items with the rename dialog in Folderview-Panel

Testing <= /h1> 
Rename-Dialog works for Folderview-Panel
Bugs: 306705

Diffs=

  • dolphin/src/panels/folders/folderspanel.cpp (3989862)
  • dolphin/src/settings/general/behaviorsettingspage.cpp (1ade93c)

View Diff
--===============8355860896986118375==--