[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KLook - quick preview extension for Dolphin
From:       Sergey Borovkov <serge.borovkov () gmail ! com>
Date:       2012-10-19 12:40:12
Message-ID: CACYfbRj+tFoVroxOs4khB71XV_iYbvA3OLrtqV7v8XUFwXhMEA () mail ! gmail ! com
[Download RAW message or body]

On Wed, Oct 3, 2012 at 5:04 PM, Frank Reininghaus
<frank78ac@googlemail.com>wrote:

> Hi,
>
> 2012/10/3 Sergey Borovkov <serge.borovkov@gmail.com>:
> > Yes, of course that bug will be fixed before I ask for review.
> > I just need
> > to merge my current work on KLook in master to do that (it's just a bit
> > incomplete and I am finishing it up).
> > About patch:
> > 1) I think nothing prevents to use Klook on space?
>
> Peter pointed out some time ago [1] why the "Space" shortcut for KLook
> does not provide a big usability improvement compared to the current
> situation in single-click mode (which is the default), and I agree
> with his arguments.
>
> > 2) The problem of insufficient space for icon is of course problematic, I
> > agree - may be it would be ok not to show KLook icon when there is no
> place
> > for it?
>
> If we do that, I can already see bug reports like "I enabled the KLook
> button, but Dolphin doesn't show it" coming from users who always use
> the Details View with a small icon size. And I also see that some
> users will request that we make it configurable if the selection
> markers or the "KLook" button will be hidden when there is
> insufficient space for both. In other words: such a solution would be
> a maintenance nightmare.
>
> Best regards,
> Frank
>
> [1] http://lists.kde.org/?l=kde-devel&m=133607423519253&w=2
>

Can you suggest an alternative to preview toggle? (or may be what todd rme
proposed would be acceptable?) We implemented this feature after Peter's
suggestion that KLook should be opened using one click. I am ready to
implement your suggestions on what would make KLook integration acceptable
to be used in Dolphin (I wanted to put KLook on reviewboard earlier, but I
see no point in doing that without knowing whether it can even be used...)

[Attachment #3 (text/html)]

<br><br><div class="gmail_quote">On Wed, Oct 3, 2012 at 5:04 PM, Frank Reininghaus \
<span dir="ltr">&lt;<a href="mailto:frank78ac@googlemail.com" \
target="_blank">frank78ac@googlemail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
<br>
2012/10/3 Sergey Borovkov &lt;<a \
href="mailto:serge.borovkov@gmail.com">serge.borovkov@gmail.com</a>&gt;:<br> <div \
class="im">&gt; Yes, of course that bug will be fixed before I ask for review.<br> \
&gt; I just need<br> &gt; to merge my current work on KLook in master to do that \
(it&#39;s just a bit<br> &gt; incomplete and I am finishing it up).<br>
&gt; About patch:<br>
&gt; 1) I think nothing prevents to use Klook on space?<br>
<br>
</div>Peter pointed out some time ago [1] why the &quot;Space&quot; shortcut for \
KLook<br> does not provide a big usability improvement compared to the current<br>
situation in single-click mode (which is the default), and I agree<br>
with his arguments.<br>
<div class="im"><br>
&gt; 2) The problem of insufficient space for icon is of course problematic, I<br>
&gt; agree - may be it would be ok not to show KLook icon when there is no place<br>
&gt; for it?<br>
<br>
</div>If we do that, I can already see bug reports like &quot;I enabled the KLook<br>
button, but Dolphin doesn&#39;t show it&quot; coming from users who always use<br>
the Details View with a small icon size. And I also see that some<br>
users will request that we make it configurable if the selection<br>
markers or the &quot;KLook&quot; button will be hidden when there is<br>
insufficient space for both. In other words: such a solution would be<br>
a maintenance nightmare.<br>
<br>
Best regards,<br>
Frank<br>
<br>
[1] <a href="http://lists.kde.org/?l=kde-devel&amp;m=133607423519253&amp;w=2" \
target="_blank">http://lists.kde.org/?l=kde-devel&amp;m=133607423519253&amp;w=2</a><br>
 </blockquote></div><br><div>Can you suggest an alternative to preview toggle? (or \
may be what todd rme proposed would be acceptable?) We implemented this feature after \
Peter&#39;s suggestion that KLook should be opened using one click. I am ready to \
implement your suggestions on what would make KLook integration acceptable to be used \
in Dolphin (I wanted to put KLook on reviewboard earlier, but I see no point in doing \
that without knowing whether it can even be used...)</div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic