[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KLook - quick preview extension for Dolphin
From:       Sergey Borovkov <serge.borovkov () gmail ! com>
Date:       2012-10-03 8:17:28
Message-ID: CACYfbRhc0dJjoNW7MmmL3wVTu-y87oz1BewiM2xY8Ti66zjb4w () mail ! gmail ! com
[Download RAW message or body]

Yes, of course that bug will be fixed before I ask for review. I just need
to merge my current work on KLook in master to do that (it's just a bit
incomplete and I am finishing it up).
About patch:
1) I think nothing prevents to use Klook on space?
2) The problem of insufficient space for icon is of course problematic, I
agree - may be it would be ok not to show KLook icon when there is no place
for it?

On Wed, Oct 3, 2012 at 12:08 PM, Frank Reininghaus <frank78ac@googlemail.com
> wrote:

> Hi Sergey,
>
> 2012/10/2 Sergey Borovkov <serge.borovkov@gmail.com>:
> > Hi! Sorry that I have not been writing here for some time, I was quite
> busy.
> > Since a lot of time passed and no objections raised anyone minds if I put
> > Klook on kdereview? I would like to do in week or so (I am just finishing
> > cleanup of code and proper support of remote files).
> > I am still not sure what to do about icons overlapping when they are too
> > small unfortunately
>
> I don't see how we could include the Dolphin patch unless someone has
> a good idea to resolve this issue (unfortunately, I don't have one).
>
> However, you are free to submit the KLook application for review, of
> course. I would recommend to fix the "always crashes at startup" part
> before though. Asking people to review an application in such a state
> is IMHO not a very nice thing to do.
>
> Best regards,
> Frank
>

[Attachment #3 (text/html)]

Yes, of course that bug will be fixed before I ask for review. I just need to merge \
my current work on KLook in master to do that (it&#39;s just a bit incomplete and I \
am finishing it up).  <div>About patch:</div><div>1) I think nothing prevents to use \
Klook on space?</div> <div>2) The problem of insufficient space for icon is of course \
problematic, I agree - may be it would be ok not to show KLook icon when there is no \
place for it?  <br><br><div class="gmail_quote">On Wed, Oct 3, 2012 at 12:08 PM, \
Frank Reininghaus <span dir="ltr">&lt;<a href="mailto:frank78ac@googlemail.com" \
target="_blank">frank78ac@googlemail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Sergey,<br> <br>
2012/10/2 Sergey Borovkov &lt;<a \
href="mailto:serge.borovkov@gmail.com">serge.borovkov@gmail.com</a>&gt;:<br> \
<div><div class="h5">&gt; Hi! Sorry that I have not been writing here for some time, \
I was quite busy.<br> &gt; Since a lot of time passed and no objections raised anyone \
minds if I put<br> &gt; Klook on kdereview? I would like to do in week or so (I am \
just finishing<br> &gt; cleanup of code and proper support of remote files).<br>
&gt; I am still not sure what to do about icons overlapping when they are too<br>
&gt; small unfortunately<br>
<br>
</div></div>I don&#39;t see how we could include the Dolphin patch unless someone \
has<br> a good idea to resolve this issue (unfortunately, I don&#39;t have one).<br>
<br>
However, you are free to submit the KLook application for review, of<br>
course. I would recommend to fix the &quot;always crashes at startup&quot; part<br>
before though. Asking people to review an application in such a state<br>
is IMHO not a very nice thing to do.<br>
<br>
Best regards,<br>
Frank<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]