[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KLook - quick preview extension for Dolphin
From:       Sergey Borovkov <serge.borovkov () gmail ! com>
Date:       2012-08-30 6:25:43
Message-ID: CACYfbRg_ORrAvVopHcSLeA4vg6RRNoVJxDCTv4okPJSn3AObSw () mail ! gmail ! com
[Download RAW message or body]

1) Yes, I know about that. It's kind of development version on git now.
I've been fixing that.
2) That's strange, I don't have such behavior. Will test it soon.
3) Yeah, that's why I said that this patches may not be optimal :) Of
course we need to have proper solution for this, but it's not obvious

On Thu, Aug 30, 2012 at 10:07 AM, Frank Reininghaus <
frank78ac@googlemail.com> wrote:

> 2012/8/29 Sergey Borovkov:
> > Here. This time fixed. Should blame my own stupidity (forgot to add 2
> files
> > before doing git diff). For convenience I united 2 patches in 1.
>
> Thanks. I could build the patched Dolphin and KLook now (after
> removing the erroneous ")" from CMakeLists.txt).
>
> I found a couple of problems:
>
> 1. When opening KLook by clicking the "preview toggle" or pressing
> space, it always crashes with the attached backtrace.
>
> 2. When clicking the "preview toggle" of an item, the item is not only
> previewed, but also opened.
>
> 3. (the most serious one): If the icon size is small, the selection
> marker and the "preview toggle" overlap. I have no good idea what to
> do about this :-(
>
> Best regards,
> Frank
>

[Attachment #3 (text/html)]

1) Yes, I know about that. It&#39;s kind of development version on git now. I&#39;ve \
been fixing that.<div>2) That&#39;s strange, I don&#39;t have such behavior. Will \
test it soon.</div><div>3) Yeah, that&#39;s why I said that this patches may not be \
optimal :) Of course we need to have proper solution for this, but it&#39;s not \
obvious  <br> <br><div class="gmail_quote">On Thu, Aug 30, 2012 at 10:07 AM, Frank \
Reininghaus <span dir="ltr">&lt;<a href="mailto:frank78ac@googlemail.com" \
target="_blank">frank78ac@googlemail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> 2012/8/29 Sergey Borovkov:<br>
<div class="im">&gt; Here. This time fixed. Should blame my own stupidity (forgot to \
add 2 files<br> &gt; before doing git diff). For convenience I united 2 patches in \
1.<br> <br>
</div>Thanks. I could build the patched Dolphin and KLook now (after<br>
removing the erroneous &quot;)&quot; from CMakeLists.txt).<br>
<br>
I found a couple of problems:<br>
<br>
1. When opening KLook by clicking the &quot;preview toggle&quot; or pressing<br>
space, it always crashes with the attached backtrace.<br>
<br>
2. When clicking the &quot;preview toggle&quot; of an item, the item is not only<br>
previewed, but also opened.<br>
<br>
3. (the most serious one): If the icon size is small, the selection<br>
marker and the &quot;preview toggle&quot; overlap. I have no good idea what to<br>
do about this :-(<br>
<br>
Best regards,<br>
Frank<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]