'Re: Review Request: Bug 304541 - dolphin doesn't detect correct 'Places' place when opening director'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request: Bug 304541 - dolphin doesn't detect correct 'Places' place when opening director
From:       "Frank Reininghaus" <frank78ac () googlemail ! com>
Date:       2012-08-23 13:14:23
Message-ID: 20120823131423.20399.84679 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106074/#review17898
-----------------------------------------------------------

Ship it!


Thanks for the patch! Looks very good, please push to 4.9 and master.

- Frank Reininghaus


On Aug. 18, 2012, 1:18 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106074/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 1:18 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Select the correct item in places-panel, when a directory is opened.
> 
> 
> This addresses bug 304541.
>     http://bugs.kde.org/show_bug.cgi?id=304541
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp 429c539 
> 
> Diff: http://git.reviewboard.kde.org/r/106074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106074/">http://git.reviewboard.kde.org/r/106074/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! \
Looks very good, please push to 4.9 and master.</pre>  <br />







<p>- Frank</p>


<br />
<p>On August 18th, 2012, 1:18 p.m., Emmanuel Pescosta wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>


<p style="color: grey;"><i>Updated Aug. 18, 2012, 1:18 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Select the correct item in places-panel, when a directory is \
opened.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=304541">304541</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(429c539)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106074/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic