[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] New feature: closed tabs trash bin as in Opera
From:       Eduardo Robles Elvira <edulix () gmail ! com>
Date:       2007-02-25 0:39:29
Message-ID: 200702250139.35490.edulix () gmail ! com
[Download RAW message or body]


El Domingo, 25 de Febrero de 2007, David Faure escribió:
> No, locking is used to disable the undo action while an undo job is already
> in progress. Undo is disabled while khtml is loaded because of the code in
> KonqMainWindow::slotUndoAvailable (it asks the part whether is
> "supportsUndo").

Uhm, then this needs to be revised as you say =)

> Ah, I hadn't realized all that.
> I see now that you implemented that already (sorry that I didn't have time
> to reply earlier)... I'll have a look at your new patch on Monday, but I
> would have probably said ok to having the info in both places since indeed
> it's not only about undo but also about the list in konq.... Ah well, both
> approaches are okay I think.

Currently I messed up my KDE 4 and I'm trying to rebuild it from sratch but 
I'm having some problems.

The patch has some bugs I've detected in the functions I've added to 
KUndoManager, but I sent it so you can point out anything else you detect. I 
have a patch in the works, but as I have KDE4 being compiled from svn, it 
will have to wait (I hope not for much time ;-).

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]