From kfm-devel Sun Feb 25 00:39:29 2007 From: Eduardo Robles Elvira Date: Sun, 25 Feb 2007 00:39:29 +0000 To: kfm-devel Subject: Re: [PATCH] New feature: closed tabs trash bin as in Opera Message-Id: <200702250139.35490.edulix () gmail ! com> X-MARC-Message: https://marc.info/?l=kfm-devel&m=117236401211065 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1183016.EZiJO6U4uc" --nextPart1183016.EZiJO6U4uc Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline El Domingo, 25 de Febrero de 2007, David Faure escribi=F3: > No, locking is used to disable the undo action while an undo job is alrea= dy > in progress. Undo is disabled while khtml is loaded because of the code in > KonqMainWindow::slotUndoAvailable (it asks the part whether is > "supportsUndo"). Uhm, then this needs to be revised as you say =3D) > Ah, I hadn't realized all that. > I see now that you implemented that already (sorry that I didn't have time > to reply earlier)... I'll have a look at your new patch on Monday, but I > would have probably said ok to having the info in both places since indeed > it's not only about undo but also about the list in konq.... Ah well, both > approaches are okay I think. Currently I messed up my KDE 4 and I'm trying to rebuild it from sratch but= =20 I'm having some problems. The patch has some bugs I've detected in the functions I've added to=20 KUndoManager, but I sent it so you can point out anything else you detect. = I=20 have a patch in the works, but as I have KDE4 being compiled from svn, it=20 will have to wait (I hope not for much time ;-). --nextPart1183016.EZiJO6U4uc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBF4NrHKJ3W9yjkCCMRAvWxAKDRociJjEx1CbBcoEoxxXRkqppyagCfcyq7 qiF4quzKDUttXGAIfwuoXoU= =AaKA -----END PGP SIGNATURE----- --nextPart1183016.EZiJO6U4uc--