[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [patch] #69130: buttons,
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2003-12-07 13:12:48
[Download RAW message or body]

Hi,
we are taking great pains to ensure that widgets don't erase on repaint, yet 
RenderWidget::updateFromElement() does not seem to agree :)

Please review,
Germain
["render_replaced.cpp.diff" (text/x-diff)]

Index: rendering/render_replaced.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/rendering/render_replaced.cpp,v
retrieving revision 1.152
diff -u -3 -p -B -r1.152 render_replaced.cpp
--- rendering/render_replaced.cpp	5 Dec 2003 18:43:46 -0000	1.152
+++ rendering/render_replaced.cpp	7 Dec 2003 12:52:33 -0000
@@ -247,7 +247,6 @@ void RenderWidget::updateFromElement()
             int lowlightVal = 100 + (2*contrast_+4)*10;
 
             if (backgroundColor.isValid()) {
-                widget()->setEraseColor(backgroundColor );
                 for ( int i = 0; i < QPalette::NColorGroups; i++ ) {
                     pal.setColor( (QPalette::ColorGroup)i, QColorGroup::Background, \
                backgroundColor );
                     pal.setColor( (QPalette::ColorGroup)i, QColorGroup::Light, \
backgroundColor.light(highlightVal) );



[prev in list] [next in list] [prev in thread] [next in thread]