From kfm-devel  Sun Dec 07 13:12:48 2003
From: Germain Garand <germain () ebooksfrance ! org>
Date: Sun, 07 Dec 2003 13:12:48 +0000
To: kfm-devel
Subject: [patch] #69130: buttons,
X-MARC-Message: https://marc.info/?l=kfm-devel&m=107080236612474
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_Qdy0/RiaZhjYedH"


--Boundary-00=_Qdy0/RiaZhjYedH
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Hi,
we are taking great pains to ensure that widgets don't erase on repaint, yet 
RenderWidget::updateFromElement() does not seem to agree :)

Please review,
Germain
--Boundary-00=_Qdy0/RiaZhjYedH
Content-Type: text/x-diff; charset="us-ascii"; name="render_replaced.cpp.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="render_replaced.cpp.diff"

Index: rendering/render_replaced.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/rendering/render_replaced.cpp,v
retrieving revision 1.152
diff -u -3 -p -B -r1.152 render_replaced.cpp
--- rendering/render_replaced.cpp	5 Dec 2003 18:43:46 -0000	1.152
+++ rendering/render_replaced.cpp	7 Dec 2003 12:52:33 -0000
@@ -247,7 +247,6 @@ void RenderWidget::updateFromElement()
             int lowlightVal = 100 + (2*contrast_+4)*10;
 
             if (backgroundColor.isValid()) {
-                widget()->setEraseColor(backgroundColor );
                 for ( int i = 0; i < QPalette::NColorGroups; i++ ) {
                     pal.setColor( (QPalette::ColorGroup)i, QColorGroup::Background, backgroundColor );
                     pal.setColor( (QPalette::ColorGroup)i, QColorGroup::Light, backgroundColor.light(highlightVal) );

--Boundary-00=_Qdy0/RiaZhjYedH--