[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: good news: nspluginviewer HTTP POST Support
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-11-05 19:20:48
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 05 November 2002 20:07, Till Krech wrote:
> The requested URL is
> javascript:flashworker_popup("herrensahne/hs7frameset.html", "hs07", \
> "width=740,height=790,screenX=200,left=0,screenY=0,top=0,toolbar=0,menubar=0,location=0,status=1,resizable=yes,scrollbars=0")
>  The target is "_parent"

Hmm is it supposed to _return_ a string from that method, and use it as the contents
of the frame, or simply to call that method?
If the latter, this patch might be enough. If the former, the TODO has to be \
implemented :) (For this, the code in slotRedirect() or the code line 2923 \
(requestFrame) might help. Hmm, in fact simply calling requestFrame might be all \
that's needed...).

diff -u -p -r1.762 khtml_part.cpp
- --- khtml_part.cpp	2002/11/04 19:39:37	1.762
+++ khtml_part.cpp	2002/11/05 19:17:46
@@ -3513,6 +3513,13 @@ void KHTMLPart::slotChildURLRequest( con
 {
   khtml::ChildFrame *child = frame( sender()->parent() );
 
+  // TODO: handle child target correctly! currently the script are always executed \
fur the parent +  QString urlStr = url.url();
+  if ( urlStr.find( QString::fromLatin1( "javascript:" ), 0, false ) == 0 ) {
+      executeScript( urlStr.right( urlStr.length() - 11) );
+      return;
+  }
+
   QString frameName = args.frameName.lower();
   if ( !frameName.isEmpty() )
   {
@@ -3546,13 +3553,6 @@ void KHTMLPart::slotChildURLRequest( con
 
       child = _frame;
     }
- -  }
- -
- -  // TODO: handle child target correctly! currently the script are always executed \
                fur the parent
- -  QString urlStr = url.url();
- -  if ( urlStr.find( QString::fromLatin1( "javascript:" ), 0, false ) == 0 ) {
- -      executeScript( urlStr.right( urlStr.length() - 11) );
- -      return;
   }
 
   if ( child ) {


> > Can we apply this to CVS asap?  Hopefully there will be an RC3 so it can
> > go in.
> Who decides in this phase wether the patch can go in or not ?
Other developers (e.g. at least one other developer, involved with the app or lib).

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9yBoQ72KcVAmwbhARAiSAAJ0fMKq+FzyhZrGneYP0oOQeAfqW+wCglAGP
47bUGy1sNzCVO00nwrBIaFM=
=WQsT
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]