[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: good news: nspluginviewer HTTP POST Support
From:       Till Krech <till () snafu ! de>
Date:       2002-11-05 19:07:46
[Download RAW message or body]

On Tuesday 05 November 2002 06:32, George Staikos wrote:
> On November 2, 2002 18:00, Till Krech wrote:
> > > This sounds great.  This is, imho, a bugfix and should go into 3.1.
> > > Previously pages that did this did not work.  Now they at least
> > > partially work.  Does anyone else approve?
> > 
> > This is not the only bugfix in this patch (and the khtml patch):
> > - java 1.3.1 plugin working
> > - size problem fixed
> > - javascript: links work now (http://www.cocacola.com)
> > - less crashes due to controlled memory management
> > - debuggability for developers (enableDebugOutput, runWithValgrind)
> > - (more) correct plugin scanning
> > 
> > The patch needs some cleanup though and it perhaps produces some small
> > memory leaks but normally the viewer does not run very long and it's
> > better than crashing or hanging in endless loops in malloc which I
> > observed before.
> 
> I didn't really have any problems so far with it.
> 
> I did notice that www.shockwave.com still gives "Unsupported protocol
> javascript" boxes though.  I didn't try the java plugin yet.
I did not find this problem on shockwave.com but somewhere else:
http://www.pigsell.com/
Click on 'Illustration' then on the next page on 'Comic' and then on 'Herrensahne #7'

I attached a gdb and got the following stacktrace (interesting part of it)
The requested URL is
javascript:flashworker_popup("herrensahne/hs7frameset.html", "hs07", \
"width=740,height=790,screenX=200,left=0,screenY=0,top=0,toolbar=0,menubar=0,location=0,status=1,resizable=yes,scrollbars=0")
 The target is "_parent"

#6  0x40606ac7 in KMessageBox::error (parent=0x0, text=@0xbfffe8d4, \
caption=@0x41075e98, options=1)  at /home/till/kde+/kdelibs/kdeui/kmessagebox.cpp:602
#7  0x40069d84 in KonqMainWindow::openURL (this=0x80f6058, _view=0x81eb560, \
_url=@0xbfffeb68,  _serviceType=@0xbfffeba0, req=@0xbfffe988, trustedSource=false)
    at /home/till/kde+/kdebase/konqueror/konq_mainwindow.cc:402
#8  0x4006c077 in KonqMainWindow::openURL (this=0x80f6058, childView=0x81eb560, \
url=@0xbfffeb68, args=@0xbfffeb90)  at \
/home/till/kde+/kdebase/konqueror/konq_mainwindow.cc:770 #9  0x4006bdae in \
KonqMainWindow::slotOpenURLRequest (this=0x80f6058, url=@0xbfffeb68, \
args=@0xbfffeb90)  at /home/till/kde+/kdebase/konqueror/konq_mainwindow.cc:748
#10 0x40085de1 in KonqMainWindow::qt_invoke (this=0x80f6058, _id=78, _o=0xbfffeafc) \
at konq_mainwindow.moc:463 #11 0x40bdb07a in QObject::activate_signal \
(this=0x8392748, clist=0x839e018, o=0xbfffeafc)  at kernel/qobject.cpp:2214
---Type <return> to continue, or q <return> to quit---
#12 0x4019a911 in KParts::BrowserExtension::openURLRequestDelayed (this=0x8392748, \
t0=@0xbfffeb68, t1=@0xbfffeb90)  at browserextension.moc:253
#13 0x40199536 in KParts::BrowserExtension::slotEmitOpenURLRequestDelayed \
(this=0x8392748)  at /home/till/kde+/kdelibs/kparts/browserextension.cpp:420

It seems that the problem is in the function KHTMLPart::slotChildURLRequest which \
does emit d->m_extension->openURLRequest( url, newArgs );
on the KHTMLPartBrowserExtension

Is there anybody able to tell what has to be changed to handle the javascript url ?
If the target is "_self", it works.

> 
> Can we apply this to CVS asap?  Hopefully there will be an RC3 so it can
> go in.
Who decides in this phase wether the patch can go in or not ?

regards, till 
> 
> Thanks

-- 
Till Krech from Berlin, Germany is happy with
SuSE Linux 8.0 (i386) 2.4.18-64GB-SMP * KDE: 3.0.98 (KDE 3.1 RC2)
Qt: 3.1.0 * gcc version 3.2


[prev in list] [next in list] [prev in thread] [next in thread]