[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Turbo gif
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2002-03-31 14:17:18
[Download RAW message or body]



On Tue, 19 Mar 2002, Koos Vriezen wrote:

> Can you watch http://www.cometpeetarno.demon.nl/ then?
>
Turns out that this ImageReady generated page never gets to the
KHTMLView::timerEvent (for an AMD K6-300). The timer is already destroyed
by KHTMLView::scheduleRepaint or discarded by Qt. If I do

--- khtmlview.cpp       2002/03/25 13:30:27     1.463
+++ khtmlview.cpp       2002/03/31 14:06:09
@@ -1486,9 +1486,10 @@ void KHTMLView::scheduleRepaint(int x, i
         d->updateRect = d->updateRect.unite(QRect(x,y,w,h));
     } else
         d->updateRect = QRect(x,y,w,h);
-
-    d->repaintTimerId = startTimer( time );
-
+    if (time)
+      d->repaintTimerId = startTimer( time );
+    else
+      updateContents( d->updateRect );
 //     kdDebug() << "starting timer " << time << endl;
 }

page is rendered correctly. Don't know what horror might happen by
bypassing this scheduler, but so far no troubles. (btw, this is not a
proposed patch ;)

Comparing the the CPU usage (100%) with mozilla (50%), means its still not
optimal. Maybe bypassing the repaintRectangle for non-transparent movies?
Any ideas?

Regards,

Koos Vriezen


[prev in list] [next in list] [prev in thread] [next in thread]