[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    PATCH: fixing my banking site ;)'
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-03-19 23:37:12
[Download RAW message or body]

Well, it's simply about <iframe id="myiframe"> and then using
window.frames["myiframe"].
This failed because the id attribute of frames/iframes was ignored - for some reason
there was a test for XHTML conformance, and looking at ids only in XHTML mode.
Simply removing this test fixes the page.
The support for ATTR_ID, with this test, was added by Dirk during the big
"Christmas hacking" commit. Is it okay to remove the test?

(BTW, Dirk, I had a look at how to implement a frames collection... but
a frame isn't a NodeImpl, so this doesn't really fit into the HTMLCollection design.
It's a collection of window object, i.e. of KHTMLParts.
Plus, the handling of synonyms isn't the same (in IE) as with normal collections.
I think the current FrameArray (and KHTMLPart::findFrame) stuff is fine).

Index: html_baseimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/html/html_baseimpl.cpp,v
retrieving revision 1.157
diff -u -p -r1.157 html_baseimpl.cpp
--- html_baseimpl.cpp   2002/03/03 23:21:59     1.157
+++ html_baseimpl.cpp   2002/03/19 23:36:58
@@ -231,7 +231,8 @@ void HTMLFrameElementImpl::parseAttribut
         url = khtml::parseURL(attr->val());
         break;
     case ATTR_ID:
-        if (getDocument()->htmlMode() != DocumentImpl::XHtml) break;
+        // Commented this out. Fixes my banking site, it uses <iframe id="myiframe"> - David.
+        //if (getDocument()->htmlMode() != DocumentImpl::XHtml) break;
         // fall through
     case ATTR_NAME:
         name = attr->value();

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
[prev in list] [next in list] [prev in thread] [next in thread]