[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KIO/KHTML Error Handling Update
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2002-01-27 22:58:48
[Download RAW message or body]

On Sunday 27 January 2002 10:01, Hamish Rodda wrote:
> > Much more efficient to keep the KURL::List returned by split and iterate
> > over it.
>
> ok
>
> >More important remark: why use error:// in the sub URL ? My idea was that
> > it
>
> ok... subconsciously I was thinking about keeping it secure, but I guess an
> outsider can append an error sub-url on the end anyway.
>
> >* the konq_run patch is missing, right ? ;)
>
> I had committed that too, commented out, but here it is again (will switch
> the URL order...):
>
> void KonqRun::handleError( KIO::Job *job )
> {
> +    KURL subURL = QString("error:///?error=%1&errText=%2")
> +                        .arg( job->error() ).arg( job->errorString() );
> +
> +    QStringList stringL;
> +    stringL << m_strURL.url() << subURL.url();
> +
> +    m_strURL = KURL::join( stringL );
>
>     m_job = 0;
>     foundMimeType( "text/html" );
> }

An offhand comment, suggestion, whatever you want to call it.  Please refrain from using 
error:// if the protocol you are defining contains no hostname.  Instead using "error:/" or 
"error:" is sufficient ; so we won't end up breaking set specifications (namely RFC 2396).

Regards,
Dawit A.
[prev in list] [next in list] [prev in thread] [next in thread]