[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KIOSlave errors an konqueror's handling of them
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-01-25 15:11:31
[Download RAW message or body]

On Friday 25 January 2002 15:56, Hamish Rodda wrote:
> >Yup, but you also need to add support for error:// in khtml, and call it in
> >KonqRun::handleError()  (as I see it)
> 
> I was just going to hack away at KHTMLPart... pseudo code:
> 
> void KHTMLPart::showError( KIO::Job* job )
> if user wants html error pages
> call and write data from buildHTMLErrorString
> otherwise call and write data from buildErrorString

Yes, that's the necessary good start, although it would help if you would make 
that code another protected method, called by showError, so that it can take 
the errorcode, errorstring and URL as argument. Those would come from the job 
in the above case, but they could come from the error:// URL in case the 
error was detected by KonqRun.

I was just saying that this isn't enough to fix the "get() after a stat() that 
gave an error" problem, for that the error:// support has to be added (in 
khtml it's simply about retrieving the 3 params from the url, and calling the 
method I'm talking about above). And in Konq it's simply about setting 
m_strURL to that URL, in KonqRun::handleError.
 
> Now, is there any way I could include active links to KDE services, such as 
> control panel options, without being validly criticised for introducing 
> security concerns?

I think there should be no problem, you can simply add a bool that authorizes 
execution of programs and scripts w/o confirmation, and setting this bool to 
true in showError().

> And, where/who should I ask about getting the format right for i18n stuff, 
ie 
> the merits of docbook vs. plain html?
Hmm, kde-i18n-doc@kde.org

> I asked on #kde if anyone wanted to help... they asked if I would pay them:)
Lazy bast...s ;)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david, http://www.konqueror.org
KDE 3.0: Konquering the Desktops
[prev in list] [next in list] [prev in thread] [next in thread]