[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH adds PluginInterface to KonqPopupMenu
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2001-10-30 10:40:20
[Download RAW message or body]

On Mon, Oct 29, 2001 at 07:46:18PM +0100, Holger Freyther wrote:
> > > Then the XMLGUI stuff will be done. There will be three way of doing
> > > this. Either manipulate the menu directly with popup->insertItem( )... (
> > > sometimes
> >
> > I seriously hope no plugin will do that. I'll just mess up the
> > merging and everything. But anyway, we can't prevent it,
> > unfortunately.
> Fortunately I'm going to do this. You the disknavigator in kicker? Actually
> I think something like Copy to -> and then the entries woud be cool
> but to do initialize  every dir and add it to konqpopupmenu ist bit to load 
> intensive
> I'm going to a dummy entry
> and in slotXMLGUIFinished I'll replace my dummy entry with a real submenu and 
> adds the quick copy to it.

That sounds like a hack to me. I think a better/cleaner approach is
to utilize a KActionMenu for that. I don't think we should add a
'slotXMLGUIFinished' just for that.

> > > needed ), to load a xml gui client or functions like the ones in
> > > konq_popupmenu.cc for convience when mainpulating the xml gui by hand (
> > > shouldn't be needed ) but the whole point of a plugin is to be dynamic
> > > (to which degree?).
> >
> > Hmmm, you're right here. We need the dynamic aspect. This in fact
> > sounds like a generally interesting idea. Maybe it would make sense
> > to move the code for building an 'xmlgui' conformant DOM document at
> > run-time into a separate class. Sounds like useful functionality and
> > maximum code reuse we'd have, too, because KonqPopupMenu itself
> > could utilize (aggregate or inherit) that class, as well as the
> > plugin. Ah, that in fact justifies a KonqPopupMenuPlugin class for
> > real :-)
> Inheritance should be good
> class KonqXMLManipulator : KXMLGUIClient {}
> class KonqPopupMenu : KonqXMLManipulator : QPopupMenu {}

Yup :) Maybe KonqXMLManipulator doesn't even need to inherit from
KXMLGUIClient (or does it need any specific functionality of
KXMLGUIClient?)
 
> > > PS: Then there could be a dir in kdeaddons which shows all kind of
> > > popupmenus for different apps
> >
> > Yup. Out of curiousity: What kind of plugins are you thinking of? :)
> I think of Quick Copy Quick Move with some kind of caching.
> but the rest is my secret. I will make my gallerycreator a plugin once it's 
> finished. 

Cool :)


Simon

[prev in list] [next in list] [prev in thread] [next in thread]