[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: CSSMediaRuleImpl::cssRules()
From:       Lars Knoll <knoll () kde ! org>
Date:       2001-09-24 12:17:18
[Download RAW message or body]

On Monday 24 September 2001 14:01, Martijn Klingens wrote:
> Is the current implementation of CSSMediaRuleImpl::cssRules() a stub or is
> it supposed to be correct?
>
> There is no "// ###" in the implementation, unlike the
> insertRule/deleteRule classes. But all it does is 'return this;', about the
> last thing I'd expect.
>
> I didn't quite think of a class CSSMediaRule being a list, and the comment
> in css_ruleimpl.h seems to suggest the same. Quoting:
>
> ----
> // @media needs a list...
> // ### I'd prefer having CSSRuleImpl derived from StyleBaseImpl only,
> though. class CSSRuleImpl : public StyleListImpl
> ----
>
> Is there a reason for this instead of having a protected member
>
> CSSRuleList m_list;
>
> as I somehow expected? If not then I'd like to change this to better
> reflect the API...

There probably was a reason back in the old days, but I don't really remember 
it anymore. I haven't (and so has noone else) touched that part of code for 
ages.

According to the DOM specs, CSSMediaRule has a CSSRuleList as member, so feel 
free to make the changes.

Lars

[prev in list] [next in list] [prev in thread] [next in thread]