[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-crypto-vger
Subject:    AW: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify code
From:       Walter Harms <wharms () bfs ! de>
Date:       2021-04-28 9:34:58
Message-ID: c621542318e644239008eea5f670390e () bfs ! de
[Download RAW message or body]

It is also possible to drop the else and simplify
further.

hlist_for_each_entry(chunk, &queue->chead, nextchunk)
if (chunk != queue->qhead) {
                                queue->qhead = chunk;
                                break;
                        }

re,
 wh
________________________________________
Von: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Gesendet: Mittwoch, 28. April 2021 09:33:37
An: gcherian@marvell.com; herbert@gondor.apana.org.au; davem@davemloft.net
Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; \
                kernel-janitors@vger.kernel.org; Christophe JAILLET
Betreff: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify code

WARNUNG: Diese E-Mail kam von außerhalb der Organisation. Klicken Sie nicht auf Links \
oder öffnen Sie keine Anhänge, es sei denn, Sie kennen den/die Absender*in und \
wissen, dass der Inhalt sicher ist.


Use 'hlist_for_each_entry' instead of hand writing it.
This saves a few lines of code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
 drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c \
b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c index 4fe7898c8561..feb0f76783dd \
                100644
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -244,11 +244,7 @@ static int send_cpt_command(struct cpt_vf *cptvf, union \
cpt_inst_s *cmd,  memcpy(ent, (void *)cmd, qinfo->cmd_size);

        if (++queue->idx >= queue->qhead->size / 64) {
-               struct hlist_node *node;
-
-               hlist_for_each(node, &queue->chead) {
-                       chunk = hlist_entry(node, struct command_chunk,
-                                           nextchunk);
+               hlist_for_each_entry(chunk, &queue->chead, nextchunk) {
                        if (chunk == queue->qhead) {
                                continue;
                        } else {
--
2.30.2


[prev in list] [next in list] [prev in thread] [next in thread]