It is also possible to drop the else and simplify further. hlist_for_each_entry(chunk, &queue->chead, nextchunk) if (chunk !=3D queue->qhead) { queue->qhead =3D chunk; break; } re, wh ________________________________________ Von: Christophe JAILLET Gesendet: Mittwoch, 28. April 2021 09:33:37 An: gcherian@marvell.com; herbert@gondor.apana.org.au; davem@davemloft.net Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-jani= tors@vger.kernel.org; Christophe JAILLET Betreff: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify co= de WARNUNG: Diese E-Mail kam von au=DFerhalb der Organisation. Klicken Sie nic= ht auf Links oder =F6ffnen Sie keine Anh=E4nge, es sei denn, Sie kennen den= /die Absender*in und wissen, dass der Inhalt sicher ist. Use 'hlist_for_each_entry' instead of hand writing it. This saves a few lines of code. Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/= cavium/cpt/cptvf_reqmanager.c index 4fe7898c8561..feb0f76783dd 100644 --- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c +++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c @@ -244,11 +244,7 @@ static int send_cpt_command(struct cpt_vf *cptvf, unio= n cpt_inst_s *cmd, memcpy(ent, (void *)cmd, qinfo->cmd_size); if (++queue->idx >=3D queue->qhead->size / 64) { - struct hlist_node *node; - - hlist_for_each(node, &queue->chead) { - chunk =3D hlist_entry(node, struct command_chunk, - nextchunk); + hlist_for_each_entry(chunk, &queue->chead, nextchunk) { if (chunk =3D=3D queue->qhead) { continue; } else { -- 2.30.2