[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitor-commits
Subject:    kernel-janitor TODO,1.16,1.17
From:       Dave Jones <davej () users ! sourceforge ! net>
Date:       2002-02-05 3:26:05
[Download RAW message or body]

Update of /cvsroot/kernel-janitor/kernel-janitor
In directory usw-pr-cvs1:/tmp/cvs-serv12358

Modified Files:
	TODO 
Log Message:
Copying to/from userspace issues.



Index: TODO
===================================================================
RCS file: /cvsroot/kernel-janitor/kernel-janitor/TODO,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- TODO	2002/02/04 17:51:06	1.16
+++ TODO	2002/02/05 03:26:03	1.17
@@ -71,12 +71,27 @@
 - de4x5.c doesn't pci_enable_device()
 
 -----------------------------------------------------------------------------
+Copying to/from userspace issues.
+- The copy_*_user() routines may sleep.
+  For this reason, they shouldn't be called with locks held, or with
+  interrupts disabled.
+- get rid of verify_area with copy_*_user get/put_user, only needed if
+  using __copy_*_user et al
+- make sure that copy_*_user return values are checked
+- use "return copy_*_user(...) ? -EFAULT : ok_value;"
+
+SUSPECTS:
+- look at drivers/char/generic_serial.c
+- look at drivers/char/n_tty.c
+- check drivers/char/dz.c wrt return copy*user(...);
+  has to be ... ? -EFAULT : 0;
+
+-----------------------------------------------------------------------------
 - get rid of panic function in drivers (watchdogs need to use machine_restart
   instead of panic -- several char drivers do this happily :(
 
 -----------------------------------------------------------------------------
 - get rid of isa_read/write[bwl], use ioremap instead
-
 	-  unsigned long addr = 0xC0000;
 	-  isa_writeb (0xC0, addr);
 	+  void *cookie = ioremap (0xC0000, region_size);
@@ -91,16 +106,6 @@
 Read Documentation/IO-mapping.txt for more details.
 -----------------------------------------------------------------------------
 - sed s/return EWHATEVER/return -EWHATEVER/
-
------------------------------------------------------------------------------
-- get rid of verify_area with copy_*_user get/put_user, only needed if
-  using __copy_*_user et al
-- make sure that copy_to_user et all are checked
-  - look at drivers/char/generic_serial.c
-  - look at drivers/char/n_tty.c
-- use "return copy_to_user(...) ? -EFAULT : ok_value;"
-  - check drivers/char/dz.c wrt return copy*user(...);
-  has to be ... ? -EFAULT : 0;
 
 -----------------------------------------------------------------------------
 Date: Wed, 14 Feb 2001 12:51:53 +0100


_______________________________________________
Kernel-janitor-commits mailing list
Kernel-janitor-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kernel-janitor-commits

[prev in list] [next in list] [prev in thread] [next in thread]