[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitor-commits
Subject:    kernel-janitor TODO,1.15,1.16
From:       Dave Jones <davej () users ! sourceforge ! net>
Date:       2002-02-04 17:51:23
[Download RAW message or body]

Update of /cvsroot/kernel-janitor/kernel-janitor
In directory usw-pr-cvs1:/tmp/cvs-serv17173

Modified Files:
	TODO 
Log Message:
undo tab damage


Index: TODO
===================================================================
RCS file: /cvsroot/kernel-janitor/kernel-janitor/TODO,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- TODO	2002/02/04 17:36:52	1.15
+++ TODO	2002/02/04 17:51:06	1.16
@@ -1,20 +1,20 @@
 Audit return codes (and handle failure correctly) for..
-	misc_register()
-	request_region()
-	register_reboot_notifier()
-	request_irq()
-	kmalloc(), vmalloc(), skb_alloc(), etc
-	register_netdev() has to be checked as well
-    misc_register() (yes, it can fail, murphy's law applies here as well)
-	scsi_register()
-	proc_*_create()
-	pci_map_* might return 0 for a valid mapping.
-	 Some code tests mapping for a non-zero value, which is incorrect.
-	get_free_pages()
-	init_etherdev()
-	 drivers allocating net_device with init_etherdev doesn't need zeroing it
-	 (init_etherdev does this for us)
-	ioremap() -- Some are using this as a pointer, which is wrong.
+- misc_register()
+- request_region()
+- register_reboot_notifier()
+- request_irq()
+- kmalloc(), vmalloc(), skb_alloc(), etc
+- register_netdev() has to be checked as well
+- misc_register() (yes, it can fail, murphy's law applies here as well)
+- scsi_register()
+- proc_*_create()
+- pci_map_* might return 0 for a valid mapping.
+  Some code tests mapping for a non-zero value, which is incorrect.
+- get_free_pages()
+- init_etherdev()
+  drivers allocating net_device with init_etherdev doesn't need zeroing it
+  (init_etherdev does this for us)
+- ioremap() -- Some are using this as a pointer, which is wrong.
 
 
 SUSPECTS:
@@ -77,12 +77,12 @@
 -----------------------------------------------------------------------------
 - get rid of isa_read/write[bwl], use ioremap instead
 
-	-       unsigned long addr = 0xC0000;
-	-       isa_writeb (0xC0, addr);
-	+       void *cookie = ioremap (0xC0000, region_size);
-	+       if (!cookie) { fail... }
-	+       writeb (0xC0, cookie);
-	+       iounmap (cookie);
+	-  unsigned long addr = 0xC0000;
+	-  isa_writeb (0xC0, addr);
+	+  void *cookie = ioremap (0xC0000, region_size);
+	+  if (!cookie) { fail... }
+	+  writeb (0xC0, cookie);
+	+  iounmap (cookie);
 
 Note there is a ioremap step at driver init time, and an iounmap step at
 driver shutdown time.  isa_xxx simply doesn't have the remap/unmap
@@ -260,8 +260,8 @@
 Donald Becker added:
 
 Easier fix:
--                       np->stats.rx_bytes += skb->len;
-+                       np->stats.rx_bytes += pkt_len;
+-   np->stats.rx_bytes += skb->len;
++   np->stats.rx_bytes += pkt_len;
 
 Grouping the writes to np->stats results in better cache usage.
 


_______________________________________________
Kernel-janitor-commits mailing list
Kernel-janitor-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kernel-janitor-commits

[prev in list] [next in list] [prev in thread] [next in thread]