[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Custom build system: Use outputmodel from outputview
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-08-17 8:22:24
Message-ID: 20120817082224.388.9999 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 22, 2012, 8:37 p.m., Andreas Pakulat wrote:
> > Patch looks good now, thanks for you work on this. Please commit as soo=
n as the other patches (which are required if I understood correctly) have =
landed in kdevplatform/kdevelop master or send me the patches as produced w=
ith git format-patch and I'll commit them.
> =
> Milian Wolff wrote:
> was this applied? i.e. can I close this review?
Yeap, otherwise I wouldn't have noticed the breakage in the "go to next/pre=
vious output mark" shortcuts :)
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105322/#review15026
-----------------------------------------------------------
On June 22, 2012, 7:11 p.m., Morten Volden wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105322/
> -----------------------------------------------------------
> =
> (Updated June 22, 2012, 7:11 p.m.)
> =
> =
> Review request for Custom Buildsystem and KDevelop.
> =
> =
> Description
> -------
> =
> This patch is related to: http://git.reviewboard.kde.org/r/104814/
> (Share code between makebuilder and external scripts). It uses the output=
model defined in outputview/outputmodel to get colored, activatable errors =
in the output window (See screenshots in http://git.reviewboard.kde.org/r/1=
04814/) =
> =
> =
> Diffs
> -----
> =
> custombuildjob.cpp dd25842 =
> custombuildsystemplugin.h 78541d2 =
> custombuildsystemplugin.cpp 0b5ef3e =
> =
> Diff: http://git.reviewboard.kde.org/r/105322/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Morten Volden
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105322/">http://git.reviewboard.kde.org/r/105322/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 22nd, 2012, 8:37 p.m., <b>Andreas \
Pakulat</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch looks good now, thanks for you work on this. Please commit as soon \
as the other patches (which are required if I understood correctly) have landed in \
kdevplatform/kdevelop master or send me the patches as produced with git format-patch \
and I'll commit them.</pre> </blockquote>
<p>On August 16th, 2012, 7:39 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">was this applied? i.e. \
can I close this review?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeap, otherwise I \
wouldn't have noticed the breakage in the "go to next/previous output \
mark" shortcuts :)</pre> <br />
<p>- Andreas</p>
<br />
<p>On June 22nd, 2012, 7:11 p.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Custom Buildsystem and KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated June 22, 2012, 7:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is related to: http://git.reviewboard.kde.org/r/104814/ \
(Share code between makebuilder and external scripts). It uses the outputmodel \
defined in outputview/outputmodel to get colored, activatable errors in the output \
window (See screenshots in http://git.reviewboard.kde.org/r/104814/) </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>custombuildjob.cpp <span style="color: grey">(dd25842)</span></li>
<li>custombuildsystemplugin.h <span style="color: grey">(78541d2)</span></li>
<li>custombuildsystemplugin.cpp <span style="color: grey">(0b5ef3e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105322/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic