[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Crash fix on empty config
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-08-17 8:21:36
Message-ID: 20120817082136.390.30020 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 13, 2012, 9:08 a.m., Andreas Pakulat wrote:
> > Hmm, shouldn't the enter-press simply add the config? At least that sounds more \
> > sane than being able to type something and then have either nothing happen or \
> > everything enabled and nothing is saved to disk later on.
>
> Milian Wolff wrote:
> will you take care of this? or has this been applied already?
>
> if the user can still trigger the assertion this should be fixed.
The code has changed significantly now, I'll retry it over the weekend. I'm not going \
to add the patch as is, since its wrong IMHO.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104927/#review13766
-----------------------------------------------------------
On May 13, 2012, 2:56 a.m., György Andrasek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104927/
> -----------------------------------------------------------
>
> (Updated May 13, 2012, 2:56 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Fixes crash when the user is trying to add the first configuration: types name and \
> presses Enter on the combobox instead of the Add button.
> Assert is triggered with idx == 0, configs.size() == 0.
>
>
> Diffs
> -----
>
> custombuildsystemconfigwidget.cpp 791b7c7
>
> Diff: http://git.reviewboard.kde.org/r/104927/diff/
>
>
> Testing
> -------
>
> Works For Me (tm)
>
>
> Thanks,
>
> György Andrasek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104927/">http://git.reviewboard.kde.org/r/104927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 13th, 2012, 9:08 a.m., <b>Andreas \
Pakulat</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hmm, shouldn't the enter-press simply add the config? At least that \
sounds more sane than being able to type something and then have either nothing \
happen or everything enabled and nothing is saved to disk later on.</pre> \
</blockquote>
<p>On August 16th, 2012, 7:41 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">will you take care of \
this? or has this been applied already?
if the user can still trigger the assertion this should be fixed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code has changed \
significantly now, I'll retry it over the weekend. I'm not going to add the \
patch as is, since its wrong IMHO.</pre> <br />
<p>- Andreas</p>
<br />
<p>On May 13th, 2012, 2:56 a.m., György Andrasek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By György Andrasek.</div>
<p style="color: grey;"><i>Updated May 13, 2012, 2:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes crash when the user is trying to add the first configuration: \
types name and presses Enter on the combobox instead of the Add button.
Assert is triggered with idx == 0, configs.size() == 0.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works For Me (tm)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>custombuildsystemconfigwidget.cpp <span style="color: \
grey">(791b7c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104927/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic