[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Changing the format of displayed value in debugger
From:       Konstantin Karganov <karganov () gmail ! com>
Date:       2010-07-19 19:43:38
Message-ID: AANLkTimhXFRkVynhsybnGobCuiIaWQDtFHHSZ4XuxIAv () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> I tried your patch, a few comments:
> - shortcuts don't work
>
 they work when the context menu is shown and actions are bound to some
variable
I'll have a look how try to make them work without menu

- Ctrl+C shortcut for copy would be nice
>
noted

> - it doesn't work for all types - how can we make that clear to the user?
> - Variable::slotSetFormat() looks hackish - does that play well with
> translations?
>
yes, sorry, I didn't thought of that, object name is not meant to be
localized while the action text is, I'll fix that.


> - not every debugger supports this feature, there must be a way to disable
> or
>  manually convert the values
>
another debugger shall introduce it's own variable class with custom
setFormat() implementation
and, for additional control there can be something like virtual bool
Variable::supportsSetFormat() to query when displaying the menu. Do you
think this needs to be done?..


> and please push your changes to gitorious, that makes it much easier
> for us to review.
> (create a personal clone)
>
I've just done as kdevelop.org says to do :)
I have cloned the git repo from gitorious, can I just push my commits up or
I'll need to register on gitorious first?..


-- 
Best regards,
Konstantin.

[Attachment #5 (text/html)]

<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt \
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

I tried your patch, a few comments:<br>
- shortcuts don&#39;t work<br></blockquote><div>  they work when the context menu is \
shown and actions are bound to some variable<br>I&#39;ll have a look how try to make \
them work without menu<br><br></div><blockquote class="gmail_quote" style="margin: \
0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

- Ctrl+C shortcut for copy would be nice<br></blockquote><div>noted \
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
                border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- it doesn&#39;t work for all types - how can we make that clear to the user?<br>
- Variable::slotSetFormat() looks hackish - does that play well with<br>
translations?<br></blockquote><div>yes, sorry, I didn&#39;t thought of that, object \
name is not meant to be localized while the action text is, I&#39;ll fix that.<br>  \
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

- not every debugger supports this feature, there must be a way to disable or<br>
   manually convert the values<br></blockquote><div>another debugger shall introduce \
it&#39;s own variable class with custom setFormat() implementation<br>and, for \
additional control there can be something like virtual bool \
Variable::supportsSetFormat() to query when displaying the menu. Do you think this \
needs to be done?..<br>  <br></div><blockquote class="gmail_quote" style="margin: 0pt \
0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

and please push your changes to gitorious, that makes it much easier<br>
for us to review.<br>
(create a personal clone)<br></blockquote><div>I&#39;ve just done as <a \
href="http://kdevelop.org">kdevelop.org</a> says to do :)<br>I have cloned the git \
repo from gitorious, can I just push my commits up or I&#39;ll need to register on \
gitorious first?..<br> </div></div><br clear="all"><br>-- <br>Best \
regards,<br>Konstantin.<br>



-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]