From kdevelop-devel Mon Jul 19 19:43:38 2010 From: Konstantin Karganov Date: Mon, 19 Jul 2010 19:43:38 +0000 To: kdevelop-devel Subject: Re: Changing the format of displayed value in debugger Message-Id: X-MARC-Message: https://marc.info/?l=kdevelop-devel&m=127956876324693 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2122338421==" --===============2122338421== Content-Type: multipart/alternative; boundary=0016e6dede3dfb9ebf048bc2c830 --0016e6dede3dfb9ebf048bc2c830 Content-Type: text/plain; charset=UTF-8 > I tried your patch, a few comments: > - shortcuts don't work > they work when the context menu is shown and actions are bound to some variable I'll have a look how try to make them work without menu - Ctrl+C shortcut for copy would be nice > noted > - it doesn't work for all types - how can we make that clear to the user? > - Variable::slotSetFormat() looks hackish - does that play well with > translations? > yes, sorry, I didn't thought of that, object name is not meant to be localized while the action text is, I'll fix that. > - not every debugger supports this feature, there must be a way to disable > or > manually convert the values > another debugger shall introduce it's own variable class with custom setFormat() implementation and, for additional control there can be something like virtual bool Variable::supportsSetFormat() to query when displaying the menu. Do you think this needs to be done?.. > and please push your changes to gitorious, that makes it much easier > for us to review. > (create a personal clone) > I've just done as kdevelop.org says to do :) I have cloned the git repo from gitorious, can I just push my commits up or I'll need to register on gitorious first?.. -- Best regards, Konstantin. --0016e6dede3dfb9ebf048bc2c830 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I tried your patch, a few comments:
- shortcuts don't work
=C2=A0they work when the co= ntext menu is shown and actions are bound to some variable
I'll have= a look how try to make them work without menu

- Ctrl+C shortcut for copy would be nice
noted
- it doesn't work for all types - how can we make that clear to the use= r?
- Variable::slotSetFormat() looks hackish - does that play well with
translations?
yes, sorry, I didn't thought of that= , object name is not meant to be localized while the action text is, I'= ll fix that.
=C2=A0
- not every debugger supports this feature, there must be a way to disable = or
=C2=A0manually convert the values
another debugger sh= all introduce it's own variable class with custom setFormat() implement= ation
and, for additional control there can be something like virtual bo= ol Variable::supportsSetFormat() to query when displaying the menu. Do you = think this needs to be done?..
=C2=A0
and please push your changes to gitorious, that makes it much easier
for us to review.
(create a personal clone)
I've just done as kdevelop.org says to do :)
I have cloned t= he git repo from gitorious, can I just push my commits up or I'll need = to register on gitorious first?..


--
Best regards,
Konstantin.
--0016e6dede3dfb9ebf048bc2c830-- --===============2122338421== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- KDevelop-devel mailing list KDevelop-devel@kdevelop.org https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel --===============2122338421==--