[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: KDev-PG-Qt and unions
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-04-24 17:19:57
Message-ID: 201004241919.59547.mail () milianw ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 24 April 2010 20:05:49 Jonathan Schmidt-Dominé - Developer wrote:
> Hi Milian!
> 
> A DefaultVisitor would work well without any flags, but have had a look at
> the PHP-plugin, duchain/expressionvisitor.cpp:
> Line 214: if(node->stringFunctionName)
> Line 236: else if(node->varFunctionName)
> php.g, lines 549 and 550:
> stringFunctionName=identifier ... | varFunctionName=variableWithoutObjects
> There would probably be a union { IdentifierAst *stringFunctionName;
> VariableWithoutObjectsAst *varFunctionName; }; the current code in
> expressionvisitor.cpp would not work any longer.

Why? Can you please explain?

> I agree that most stuff in the php-plugin does not need such information,
> but KDev-PG-Qt can not rely on that. In some cases the mentioned
> inline-methods could also be implemented without any additional bits, but
> not always...

I think I can't follow you, why we need any methods. Maybe it's just may 
limited understanding of unions.

-- 
Milian Wolff
mail@milianw.de
http://milianw.de

["signature.asc" (application/pgp-signature)]

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]